Re: RFR: 8154482: javadoc tool must support legacy doclet and taglet

2016-04-29 Thread Jonathan Gibbons
OK, but one has to wonder why ExitJavadoc is defined in Messager, and not at the top level. -- Jon On 04/29/2016 11:28 AM, Kumar Srinivasan wrote: Please review, this addresses all your comments below. http://cr.openjdk.java.net/~ksrini/8154482/webrev.02/ Thanks Kumar Start.java, line 241,

Re: RFR: 8155061: javadoc incorrectly sorted items in All Classes list and Index files

2016-04-29 Thread Jonathan Gibbons
OK On 04/29/2016 09:20 AM, Kumar Srinivasan wrote: Hello, Fixes incorrect sorting in the All Classes and Index files. https://bugs.openjdk.java.net/browse/JDK-8155061 Webrev at: http://cr.openjdk.java.net/~ksrini/8155061/webrev.00/ Thanks Kumar

Re: RFR: 8154482: javadoc tool must support legacy doclet and taglet

2016-04-29 Thread Kumar Srinivasan
Please review, this addresses all your comments below. http://cr.openjdk.java.net/~ksrini/8154482/webrev.02/ Thanks Kumar Start.java, line 241, 241, use &&, not nested if Start:490, generally, the terminology in langtools is to use "path" to mean a complete search path, as in a series of fil

RFR: 8155061: javadoc incorrectly sorted items in All Classes list and Index files

2016-04-29 Thread Kumar Srinivasan
Hello, Fixes incorrect sorting in the All Classes and Index files. https://bugs.openjdk.java.net/browse/JDK-8155061 Webrev at: http://cr.openjdk.java.net/~ksrini/8155061/webrev.00/ Thanks Kumar

Re: RFR: 8075703 "jdk.javadoc" module exports "com.sun.tools.javadoc" package which contains a lot of internal API.

2016-04-29 Thread Kumar Srinivasan
Looks ok to me. The bug should be tagged with an appropriate noreg. noreg-trivial / noreg-cleanup Kumar Please review this fix to move internal classes from an exported package. Although the webrev appears long, the work itself is fundamentally simple: Using an IDE, all classes in com.sun.