Re: RFR: 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm

2019-02-25 Thread Jonathan Gibbons
Nick, Thanks for the report, and for the analysis you did. While good, your proposed fix is not complete, as it does not address the issues in agentvm mode. Full details are in the comments in the JBS issue. I see you are a JDK Author, but not yet a Committer. I can get someone else to revie

Re: RFR: 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm

2019-02-25 Thread Jonathan Gibbons
Comment on an import statement is a long-standing request: https://bugs.openjdk.java.net/browse/JDK-4433516 -- Jon On 02/25/2019 08:16 AM, Jonathan Gibbons wrote: The test definitely looks wrong, but I'd like to understand more why the code is allowing the test to pass in agentvm mode. I susp

Re: RFR: 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm

2019-02-25 Thread Jonathan Gibbons
The test definitely looks wrong, but I'd like to understand more why the code is allowing the test to pass in agentvm mode. I suspect there's a couple of bugs that need to be filed here, against jtreg (for the different behavior of agentvm and othervm) and against javac (where it would be nice

RFR: 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm

2019-02-25 Thread Nick Gasson (Arm Technology China)
Hi, Please review this small patch to fix a failure of the above test when run with the jtreg -othervm option: Bug: https://bugs.openjdk.java.net/browse/JDK-8219628 Webrev: http://cr.openjdk.java.net/~ngasson/8219628/webrev.1/ It passes with -agentvm but with -othervm it fails with this error:

RFR : JDK-8219632: Remove reference to com.sun.javadoc API in RemoveOldDoclet test

2019-02-25 Thread Priya Lakshmi Muthuswamy
Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8219632 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8219632/webrev.00/ jdk/javadoc/tool/removeOldDoclet/RemoveOldDoclet.java tries to use OldDoclet.jasm which hold reference to removed API com.sun.javadoc. As part of th