Re: Memory leak in jdk.javadoc.internal.doclets.toolkit.WorkArounds

2019-09-27 Thread Jonathan Gibbons
Florian, I looked at the code: this is definitely a design bug. There appears to be no reason for it to be static, and removing the `static` modifier does not cause any compilation issues. There's some minor cleanup we could do in this area as well, to use Map::computeIfAbsent, Filed: http

Re: Memory leak in jdk.javadoc.internal.doclets.toolkit.WorkArounds

2019-09-27 Thread Jonathan Gibbons
Florian, Thank you for identifying and reporting this issue. I will investigate it. It is likely the item is a cache, but as a general rule, javadoc (and javac) try and avoid the use of static caches. -- Jon On 9/27/19 2:11 AM, Florian Weimer wrote: It seems that it's currently very difficult

Memory leak in jdk.javadoc.internal.doclets.toolkit.WorkArounds

2019-09-27 Thread Florian Weimer
It seems that it's currently very difficult to use the javadoc tool in a long-running VM because there is a severe memory leak. This appears to be related to the class jdk.javadoc.internal.doclets.toolkit.WorkArounds, specifically the field serializedForms. It looks like elements are never remove

RE: 8157682: @inheritDoc doesn't work with @exception

2019-09-27 Thread Yano, Masanori
Hi Jon, Thank you for your reply. I am not an OpenJDK Author as you said. I am a Contributor. So, please sponsor my change. Regards, Masanori Yano > -Original Message- > From: Jonathan Gibbons [mailto:jonathan.gibb...@oracle.com] > Sent: Thursday, September 26, 2019 12:34 PM > To: Yano,