Re: Feedback on javadoc UI changes

2019-10-09 Thread Sergey Bylokhov
Hi, Hannes. I have one unrelated suggestion. When I fixed some a11y related bugs in the specification, I have tried to check the fix by the VoiceOver tool. And it was really hard to navigate over the search_fields/links/text by the keyboard using VoiceOver. Probably it can be improved somehow.

Re: Feedback on javadoc UI changes

2019-10-09 Thread Michel Trudeau
Good catch Alex, thank you for testing this. On Oct 9, 2019, at 11:33 AM, Alex Buckley wrote: I think #2 has a serious problem. If you scroll, and then hit any key, then the search box grabs focus -- this is useful on the many occasions when you want to search, but it means that keyboard shortc

Re: Feedback on javadoc UI changes

2019-10-09 Thread Maurizio Cimadamore
#3 is the one I prefer; it is subtle (compared to #2), offer some benefits (as Alex said) in terms of screen estate, and, indirectly put the search bar front and center, as it should be. I wonder if there should be an 'up' button to hide the top bar even when you are looking at the top part of

Re: Feedback on javadoc UI changes

2019-10-09 Thread Alex Buckley
On 10/9/2019 10:29 AM, Hannes Wallnöfer wrote: The feedback we are looking for: - What do you prefer for scrolling up and down a page? Do you find the moving parts useful or distracting? I find the motion of the top blue bar and search box distracting at the first scroll, but only in the mos

Re: Feedback on javadoc UI changes

2019-10-09 Thread Stephen Colebourne
I prefer #1, and am not a fan of disappearing page parts. Stephen On Wed, 9 Oct 2019 at 18:31, Hannes Wallnöfer wrote: > > The javadoc team is considering changes to the UI of javadoc generated pages, > specifically the behaviour of the top navigation bar and navigating to > anchors within a p

Re: Memory leak in jdk.javadoc.internal.doclets.toolkit.WorkArounds

2019-10-09 Thread Florian Weimer
* Jonathan Gibbons: > I do not see any evidence of any additional leak, despite my best efforts > to find one. Sorry, I can't reproduce it either. I must have looked at the wrong heap dump, or a heap dump that wasn't restricted to just live data. So removing the static is sufficient after all.

Feedback on javadoc UI changes

2019-10-09 Thread Hannes Wallnöfer
The javadoc team is considering changes to the UI of javadoc generated pages, specifically the behaviour of the top navigation bar and navigating to anchors within a page. Since this would affect all JDK users we thought it was a good idea to present/discuss the alternatives here on jdk-dev. T