- Mail original -
> De: "Brian Goetz"
> À: "jonathan gibbons"
> Cc: "amber-dev" , "javadoc-dev"
> , "compiler-dev"
> , "Chris Hegarty"
> Envoyé: Jeudi 31 Octobre 2019 15:05:33
> Objet: Re: RFR: JEP 359-Records: javadoc code
> Let’s look at this through the lens of “what information wou
Please review:
JBS: https://bugs.openjdk.java.net/browse/JDK-8223378
Webrev: http://cr.openjdk.java.net/~hannesw/8223378/webrev.01/
API docs: http://cr.openjdk.java.net/~hannesw/8223378/api.01/
This implements the CSS Flexible Box Layout Module based page structure for the
fixed header.
I added
Aside from Chris comments on modifiers, I think the compact record
signature looks great, and adds a lot of value (which will pay further
dividends when we add pattern matching). Well done.
Annotations also look good.
Maurizio
On 30/10/2019 23:50, Jonathan Gibbons wrote:
Please review a moder
Let’s look at this through the lens of “what information would the reader want
to know about this class.” And surely, finality is one of the bits of
information the reader wants to know, because they might be wondering “can I
subclass this.” On the other hand, you might say “well of course, re
On 10/31/19 3:31 AM, Chris Hegarty wrote:
Jon,
On 30 Oct 2019, at 23:50, Jonathan Gibbons wrote:
...
Also, the sets of examples are updated, showing examples linked and not linked
to JDK API docs
http://cr.openjdk.java.net/~jjg/amber-records/examples/api-with-link/
http://cr.openjdk.java.
Jon,
> On 30 Oct 2019, at 23:50, Jonathan Gibbons
> wrote:
>
> ...
>
> Also, the sets of examples are updated, showing examples linked and not
> linked to JDK API docs
> http://cr.openjdk.java.net/~jjg/amber-records/examples/api-with-link/
> http://cr.openjdk.java.net/~jjg/amber-records/examp
