Will do.
In 15? I may try and better align the external and internal definitions
of Taglet, and/or use different/better names to better distinguish them.
-- Jon
On 12/9/19 6:22 AM, Hannes Wallnöfer wrote:
Hi Jon,
This looks good to me.
I think the internal Taglet#isBlockTag method should
Hey Jon, thanks for looking at it. I have updated the webrev. This new webrev
addresses Hannes' and yours comments:
http://cr.openjdk.java.net/~prappo/8234746/webrev.01/
-Pavel
> On 27 Nov 2019, at 21:20, Jonathan Gibbons
> wrote:
>
>
>
>
> On 11/25/2019 09:19 AM, Pavel Rappo wrote:
>
> On 25 Nov 2019, at 18:54, Hannes Wallnöfer
> wrote:
>
> Hi Pavel,
>
> Looks good to me, but two very minor enhancement suggestions:
I have changed the fix a bit, you can see the new version here:
http://cr.openjdk.java.net/~prappo/8234746/webrev.01/
> First, It’s not a big deal but the
Please review:
JBS: https://bugs.openjdk.java.net/browse/JDK-8235414
Webrev: http://cr.openjdk.java.net/~hannesw/8235414/webrev.00/
I was not sure where to put the test. I could have added it to one of the
existing tests but it didn’t seem to fit in anywhere. Since there already is a
test for i
Hi Jon,
This looks good to me.
I think the internal Taglet#isBlockTag method should be documented as well, but
no new webrev required for that.
Hannes
> Am 06.12.2019 um 02:13 schrieb Jonathan Gibbons :
>
> Please review the implementation of a change to allow taglets to support tags
> that
