RFR: JDK-8200363 Add javadoc command line setting to fail on warnings

2020-01-28 Thread Jonathan Gibbons
Please review a simple change to (finally) implement the long-overdue -Werror option. The existing undocumented -Xwerror option is repurposed and renamed, and its behavior modified to match the javac -Werror option.  The old name is retained as a alias "for a while" but since it is an undocume

Re: RFR [15] 8237909: Remove zipped index files feature

2020-01-28 Thread Pavel Rappo
Hannes, > On 28 Jan 2020, at 17:15, Hannes Wallnöfer > wrote: > > Hi Pavel, > > I fully concur with your reasoning for removing the jszip feature. Removing JSZip is incidental here. It's the whole "zipped index files" feature that is being removed. > In script.js you left in the checks whet

Re: RFR [15] 8237909: Remove zipped index files feature

2020-01-28 Thread Hannes Wallnöfer
Hi Pavel, I fully concur with your reasoning for removing the jszip feature. In script.js you left in the checks whether the *SearchIndex variables are undefined: if (!moduleSearchIndex) { ... } These if-statements can be removed as the conditions will always be true (the v

RFR [15] 8237909: Remove zipped index files feature

2020-01-28 Thread Pavel Rappo
Hello, Please review the change for https://bugs.openjdk.java.net/browse/JDK-8237909: http://cr.openjdk.java.net/~prappo/8237909/webrev.00/ This change removes the "zipped index files" feature, which was introduced as part of 8141492: Implement search feature in javadoc. The "zipped index fi