Please review a cleanup to remove some dead code and improve comments
for the tool options that are implemented in Start.preprocess.
No intentional change in functionality.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8238503
Webrev: http://cr.openjdk.java.net/~jjg/8238503/webrev/index.
Interesting ... in the old doclet, both were IllegalArgumentException.
I'm OK with fixing the javadoc; but we should not change the method
signatures in this changeset, which is about @Override and {@inheritDoc}
--Jon
On 2/4/20 1:46 PM, Pavel Rappo wrote:
Further investigation suggests that
Further investigation suggests that this artifact (a mistyped exception name)
was introduced in
changeset: 35426:374342e56a56
user:ksrini
date:Sat Nov 28 18:52:17 2015 -0800
summary: 8035473: [javadoc] Revamp the existing Doclet APIs
-Pavel
> On 4 Feb 2020,
> On 4 Feb 2020, at 19:40, Jonathan Gibbons wrote:
>
> Approved. Thanks for doing this. It may cause some short term conflicts,
> but is otherwise worthwhile.
>
> You deleted comments containing @throws in a few places, but it seems like
> nothing significant was added, so OK.
Thanks for revie
On 2/4/20 12:16 PM, Pavel Rappo wrote:
On 3 Feb 2020, at 19:58, Jonathan Gibbons wrote:
Approved, but for bonus points, add a comment to SearchIndexItem.toString
listing all the letters we use and what they are used for.
If it's okay I'd prefer not to do that. That method is pretty self-desc
> On 3 Feb 2020, at 19:58, Jonathan Gibbons wrote:
>
> Approved, but for bonus points, add a comment to SearchIndexItem.toString
> listing all the letters we use and what they are used for.
If it's okay I'd prefer not to do that. That method is pretty self-describing
and is not a part of public
Updated webrev. Only minor changes:
1. Improved comments on {Base,Html}Configuration
2. Changed locale in test to en_GB_ALLCAPS
3. Filed JDK-8238503 for ToolOption cleanup.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8222793
Webrev: http://cr.openjdk.java.net/~jjg/8222793/webrev.01/
Approved. Thanks for doing this. It may cause some short term conflicts,
but is otherwise worthwhile.
You deleted comments containing @throws in a few places, but it seems like
nothing significant was added, so OK.
-- Jon
On 2/4/20 5:21 AM, Pavel Rappo wrote:
Hello,
Please review the change
1. Javadoc comments for constructors of the HtmlConfiguration and
BaseConfiguration
classes could be updated. The comment for the HtmlConfiguration ctor could be
deleted, as there's not much value in it. The comment for the BaseConfiguration
ctor should better be updated to reflect the change in t
> On 3 Feb 2020, at 19:06, Jonathan Gibbons wrote:
>
> I concur with all the preceding discussion, about removing the zipped-files
> feature, and about the desirability of asynchronous loading if that is
> practical.
>
> Separate RFE: the UI should indicate if/while the results are incomplete
Hello,
Please review the change for https://bugs.openjdk.java.net/browse/JDK-8238467:
http://cr.openjdk.java.net/~prappo/8238467/webrev.00/
This is a blanket cleanup. The change adds missing @java.lang.Override
annotations
and removes some of the {@inheritDoc} tags. The removed {@inheritDoc}
11 matches
Mail list logo
