Thanks.
I fixed HtmlConfiguration:145
-- Jon
On 02/07/2020 08:29 AM, Pavel Rappo wrote:
Jon,
1. The patch has become a tad bit outdated after to your recent push.
Just a heads-up.
2.
145 if (locale == Locale.getDefault()) {
That looks very conservative, I would expect `equals
OK, thanks, I guess I understand ... I think you're saying that these
tests are verifying that the search indexes are not affected by any
locale setting and that (presumably) the check for locale-specific
output in the test is just a "control" to verify the test is running in
a different locale
On 02/07/2020 05:20 AM, Pavel Rappo wrote:
1. The change removes full stops from some places (e.g. @param and @return) and
adds them to others
Thanks for pointing this out; I agree with the general guideline that
@param and @return should generally use phrases and not end with a period.
2
Thank you.
-- Jon
On 02/07/2020 08:25 AM, Hannes Wallnöfer wrote:
Nice cleanup. Looks good!
Hannes
Am 07.02.2020 um 03:31 schrieb Jonathan Gibbons :
Please review a 1-file cleanup to rename and simplify Utils.WeakSoftHashMap.
Utils.WeakSoftHashMap sounds like a general collection but is
Please review:
JBS: https://bugs.openjdk.java.net/browse/JDK-8177280
Webrev: http://cr.openjdk.java.net/~hannesw/8177280/webrev.00/
As I said previously there are some things in this patch I’m unsure or not
quite happy about.
Some notes:
- While the implementation of the new DocTrees method
On 2/7/20 9:22 AM, Pavel Rappo wrote:
1. I don't know that code base well, but I'm slowly getting there. The trick
with this change is to make sure that all those configurations are
interchangeable (e.g. are the same object). Now, I understand it is*likely* to
be the case. What else could ther
Jon,
This email is NOT my approval, yet. I'll have to inspect it in more detail,
perhaps over the weekend. However, I may have some comments already.
1. I don't know that code base well, but I'm slowly getting there. The trick
with this change is to make sure that all those configurations are
int
Oh, almost forgot. The reason why there's "a somewhat surprising test case in
TestSearch" is quite trivial. That test appeared in
changeset: 52695:99eb43bc3595
user:hannesw
date:Tue Nov 27 13:02:28 2018 +0100
summary: 8213716: javadoc search not working with J
Jon,
1. The patch has become a tad bit outdated after to your recent push.
Just a heads-up.
2.
145 if (locale == Locale.getDefault()) {
That looks very conservative, I would expect `equals()`. Since it's about
a one-off optimization, it is not a big deal. I just stumbled upon that.
Nice cleanup. Looks good!
Hannes
> Am 07.02.2020 um 03:31 schrieb Jonathan Gibbons :
>
> Please review a 1-file cleanup to rename and simplify Utils.WeakSoftHashMap.
>
> Utils.WeakSoftHashMap sounds like a general collection but is specifically an
> impl of Map.
>
> Furthermore, although it
1. The change removes full stops from some places (e.g. @param and @return) and
adds them to others
2. "taglet-writer" hyphenated spelling is used inconsistently across
getTagletOutput methods in Taglet.java
3. 2-parameter getTagletOutput method specifies
@throws UnsupportedOperationException
11 matches
Mail list logo
