Re: RFR [15] 8238969: Miscellaneous cleanup

2020-02-13 Thread Jonathan Gibbons
On 2/13/20 9:32 AM, Pavel Rappo wrote: On 13 Feb 2020, at 16:00, Jonathan Gibbons wrote: On 2/13/20 7:50 AM, Pavel Rappo wrote: a. jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java:143 Shouldn't it use equals() instead of `==` in this case? A quick look shows a surprising nu

Re: RFR [15] 8238969: Miscellaneous cleanup

2020-02-13 Thread Pavel Rappo
> On 13 Feb 2020, at 16:00, Jonathan Gibbons > wrote: > > On 2/13/20 7:50 AM, Pavel Rappo wrote: >> a. jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java:143 >> >> Shouldn't it use equals() instead of `==` in this case? A quick look shows a >> surprising number of reference equal

Re: RFR [15] 8238969: Miscellaneous cleanup

2020-02-13 Thread Jonathan Gibbons
On 2/13/20 7:50 AM, Pavel Rappo wrote: a. jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java:143 Shouldn't it use equals() instead of `==` in this case? A quick look shows a surprising number of reference equality checks on javax.lang.model.element.Name and javax.lang.model.elem

RFR [15] 8238969: Miscellaneous cleanup

2020-02-13 Thread Pavel Rappo
Hello, Please review the change for https://bugs.openjdk.java.net/browse/JDK-8238969: http://cr.openjdk.java.net/~prappo/8238969/webrev.00/ During the last exploratory debugging session, I collected a number of issues that I think are worth fixing. These include: 1. Indentation, unnecessary (a