RFR: JDK-8240136: Cleanup/simplify HTML/CSS for definition lists

2020-02-27 Thread Jonathan Gibbons
Please review the next round of update for definition lists in the generated docs. The primary focus of this round is to ensure that all elements have the class attribute set. In practice, there are only two kinds of definition lists: * 1. the kind we now know as "notes", (where the eleme

Re: RFR: JDK-8239804 : Cleanup/simplify HTML/CSS for general block tags

2020-02-27 Thread Jonathan Gibbons
Pavel, Thanks for the feedback. On 2/27/20 6:29 AM, Pavel Rappo wrote: Nits 1. Since we are in this area, could you please fix the preexisting bad grammar? That is, all the occurrences of "overriden" in "TestExternalOverridenMethod" and everywhere under the test/langtools/jdk/javadoc/docl

Re: RFR: 8177280: @see {@link} syntax should allow generic types

2020-02-27 Thread Jonathan Gibbons
On 2/27/20 2:56 AM, Hannes Wallnöfer wrote: Changing RawHtml to StringContent is a significant behavioral change. It's not explicitly stated in the doc comment spec whether the text may contain HTML, but it is reasonable to infer from the descriptions of {@code} and {@literal} that it may be

Re: RFR: JDK-8239804 : Cleanup/simplify HTML/CSS for general block tags

2020-02-27 Thread Pavel Rappo
I haven't seen webrev.01, so I'll describe what I see in webrev.02. Some of the affected tests have been made to check for elements, where they previously didn't: "" For the record, it's not that those elements were not in the HTML in the first place, it's just the tests are now checking t

Re: RFR: 8177280: @see {@link} syntax should allow generic types

2020-02-27 Thread Hannes Wallnöfer
Thanks for the review, Jon. New webrev: http://cr.openjdk.java.net/~hannesw/8177280/webrev.03/ Comments inline below. > Am 25.02.2020 um 00:11 schrieb Jonathan Gibbons : > > HtmlDocletWriter:1044 > > Changing RawHtml to StringContent is a significant behavioral change. It's > not explicitly s