Also, I have nominated one of the tests to add the bug number to. In
this test, a reference to contentContainer was removed.
It seems we didn't any tests for other instances of *Container, and it
seems silly to write tests for constructions that can no longer be
generated, because the entries
Please review a moderately simple update to remove the use of `class=contentContainer>` and other similar elements from the generated
pages.
The styles associated with contentContainer and friends are moved to the
immediately enclosing element, which means they can also be
removed from the .h
Gotcha. Mea culpa. Sorry for making incorrect assumptions.
We reached synchronization just in time for me to fix it.
-- Jon
On 2/28/20 12:04 PM, Pavel Rappo wrote:
Jon, you might be confusing this directory with a similarly named
*file* TestExternalOverridenMethod.java, which you indeed rename
Jon, you might be confusing this directory with a similarly named
*file* TestExternalOverridenMethod.java, which you indeed renamed.
The directory I'm talking about is called "testExternalOverridenMethod",
and it is still there:
http://hg.openjdk.java.net/jdk/jdk/file/52367bbd4bd4/test/langtools/
Mercurial doesn't clean up empty directories, nor can I do anything to
the main repo
to make the empty directory in your repo go away.
`rmdir` is your friend.
-- Jon
On 2/28/20 11:47 AM, Pavel Rappo wrote:
That's fine. However, there's still a *directory*, called
"testExternalOverridenMethod
That's fine. However, there's still a *directory*, called
"testExternalOverridenMethod"
$ find . -iname "*overriden*"
./test/langtools/jdk/javadoc/doclet/testExternalOverridenMethod
> On 28 Feb 2020, at 19:00, Jonathan Gibbons
> wrote:
>
> On 02/28/2020 07:25 AM, Pavel Rappo wrote:
>> If it i
On 02/28/2020 07:25 AM, Pavel Rappo wrote:
If it is still possible, could you please fix the spelling in the name of the
"testExternalOverridenMethod" folder? I think we missed that yesterday while
reviewing (now pushed)http://hg.openjdk.java.net/jdk/jdk/rev/52367bbd4bd4.
Pavel,
That patch
Thanks for all the feedback.
I'm surprised I missed that occurrence of Overriden. I thought I caught
all instances. I will fix.
-- Job
On 2/28/20 7:25 AM, Pavel Rappo wrote:
On 27 Feb 2020, at 21:11, Jonathan Gibbons wrote:
Please review the next round of update for definition lists in t
> On 27 Feb 2020, at 21:11, Jonathan Gibbons
> wrote:
>
> Please review the next round of update for definition lists in the generated
> docs.
>
> The primary focus of this round is to ensure that all elements have the
> class attribute set.
>
> In practice, there are only two kinds of defi
