Meta comment:
This review is getting out of hand; I think it was a mistake for me to
have ordered my comments according to your phases, and I apologize; I
won't do it again.
---
Ther's some naming stuff and minor feedback, but I think you're getting
close.
-- Jon
On 03/09/2020 10:48 AM,
Yes, the output looks fine.
I didn't review the code so I don't consider that I should be a "Reviewer".
Roger
On 3/9/20 2:18 PM, Pavel Rappo wrote:
Thanks Roger! I reckon this is the green light from you, right?
If so, do you want me to add you as "Reviewer"?
Hopefully, we'll figure out how
Thanks Roger! I reckon this is the green light from you, right?
If so, do you want me to add you as "Reviewer"?
Hopefully, we'll figure out how to convey the fact that
there are missing s to the user real soon.
-Pavel
> On 6 Mar 2020, at 19:10, Roger Riggs wrote:
>
> Hi Pavel,
>
> The System
Jon, the replies are inline and the updated webrev is here:
http://cr.openjdk.java.net/~prappo/8239487/webrev.01/
> On 7 Mar 2020, at 01:53, Jonathan Gibbons wrote:
>
> phase-1
>
> In AbstractIndexWriter,
> the use of "anyOf" with a singleton list seems a bit weird.
I've changed methods' n
1. BodyContents, Head, Table, and TableHeader are now of type Content.
2. Navigation.Position.{TOP, BOTTOM} is used instead of `boolean top`.
PageMode's ALL_CLASSES, CONSTANT_VALUES, DOC_FILE, SERIALIZED_FORM,
SYSTEM_PROPERTIES, etc. are changed to use _ (underscore) in their names.
3. Many conve
