Re: RFR: JDK-8227046: compiler implementation for sealed classes, JDK-8227047: Javadoc for sealed types and JDK-8227044: javax.lang.model for sealed classes

2020-05-26 Thread Maurizio Cimadamore
Looks good. For the diagnostic, longer term it would be nice to generalize those: # 0: token, 1: token 2168 compiler.err.expected2=\ 2169 {0} or {1} expected 2170 2171 # 0: token, 1: token, 2: token 2172 compiler.err.expected3=\ 2173 {0}, {1}, or {2} expected 2174 2175 # 0: token, 1: to

Re: RFR: JDK-8245062 HtmlStyle: group and document members for nav, header, summary, details

2020-05-26 Thread Hannes Wallnoefer
Hi Jon, Line 198: "Note: the "Summary" information on a module declaration page would be better characterized as "Details" information." Not sure I understand the rationale behind this sentence. It seems the module page is still a summary list that links to details, although the details are on