Integrated: 8257617: TestLinkPlatform fails with new Java source version

2020-12-02 Thread Hannes Wallnöfer
On Thu, 3 Dec 2020 06:52:49 GMT, Hannes Wallnöfer wrote: > This fixes the problem that some tests in TestLinkPlatform.java rely on a > static list of properties, causing them to fail when a new Java source > version is added. The solution is to create the properties file on the fly. > > I als

Re: RFR: 8257617: TestLinkPlatform fails with new Java source version

2020-12-02 Thread Joe Darcy
On Thu, 3 Dec 2020 06:52:49 GMT, Hannes Wallnöfer wrote: > This fixes the problem that some tests in TestLinkPlatform.java rely on a > static list of properties, causing them to fail when a new Java source > version is added. The solution is to create the properties file on the fly. > > I als

RFR: 8257617: TestLinkPlatform fails with new Java source version

2020-12-02 Thread Hannes Wallnöfer
This fixes the problem that some tests in TestLinkPlatform.java rely on a static list of properties, causing them to fail when a new Java source version is added. The solution is to create the properties file on the fly. I also replaced the custom documentation domain with "example.com" as sugg

Re: RFR: JDK-8075778: Add javadoc tag to avoid duplication of return information in simple situations.

2020-12-02 Thread Pavel Rappo
On Wed, 2 Dec 2020 15:39:56 GMT, Roger Riggs wrote: >> @RogerRiggs , >> >> 1. I agree on that the lack of `.` after `}` looks unnatural: >> >> /** >> * {@return the result} Optional additional text. >> */ >> int method() { >> >> 2. I disagree on allowing a flexible expansion. This enhanceme

Re: RFR: JDK-8075778: Add javadoc tag to avoid duplication of return information in simple situations.

2020-12-02 Thread Roger Riggs
On Tue, 1 Dec 2020 17:09:25 GMT, Pavel Rappo wrote: >> /** >> * {@return the result} Optional additional text. >> */ >> ``` >> The java source looks a bit odd/unusual because the "first sentence" does >> not appear to end with a period. >> Though it seems like a convenience to include the '