Re: RFR: 8259216: javadoc omits method receiver for any nested type annotation

2021-01-11 Thread liach
On Fri, 8 Jan 2021 19:23:44 GMT, liach wrote: >> Hi, >> Please send an e-mail to dalibor.to...@oracle.com so that I can mark your >> account as verified. > > Done. A quick summary: 1. Receivers now are included if any part of their type hierarchy is annotated, such as on a type argument. Cann

Re: RFR: 8259216: javadoc omits method receiver for any nested type annotation [v3]

2021-01-11 Thread liach
> Fixes the bug where receiver type is omitted in generated Javadoc when the > immediate receiver type is not annotated (but some other type within is). > > In addition, fixed the bug where receiver type for constructor is not > properly qualified (without a clickable link), i.e. `OuterClass.thi

Integrated: Merge jdk16

2021-01-11 Thread Jesper Wilhelmsson
On Mon, 11 Jan 2021 22:04:16 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: b378f54d Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/b378f54d Stats: 139 lines in 12 files changed: 116 ins

Re: RFR: Merge jdk16 [v2]

2021-01-11 Thread Jesper Wilhelmsson
> Forwardport JDK 16 -> JDK 17 Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Merge - Changes: - all: https://git.openjdk.java.net/jdk/pull/2040/files - new: https://git.openjdk.java.net/jdk/pull/2040/files/e5

Re: RFR: 8259216: javadoc omits method receiver for any nested type annotation [v2]

2021-01-11 Thread liach
> Fixes the bug where receiver type is omitted in generated Javadoc when the > immediate receiver type is not annotated (but some other type within is). > > In addition, fixed the bug where receiver type for constructor is not > properly qualified (without a clickable link), i.e. `OuterClass.thi

Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v3]

2021-01-11 Thread Jonathan Gibbons
> Please review this change to centralize the management of HTML ids used by > the standard doclet in a single new factory class, `HtmlIds`, which utilizes > a new type-safe wrapper class around `String` called `HtmlId`. > > The new classes are used both when declaring ids (e.g. `HtmlTree.setId`

Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v2]

2021-01-11 Thread Jonathan Gibbons
> Please review this change to centralize the management of HTML ids used by > the standard doclet in a single new factory class, `HtmlIds`, which utilizes > a new type-safe wrapper class around `String` called `HtmlId`. > > The new classes are used both when declaring ids (e.g. `HtmlTree.setId`

RFR: Merge jdk16

2021-01-11 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing - 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl - 8259043: More Zero architectures need linkage with libatom

Re: RFR: 8259216: javadoc omits method receiver for any nested type annotation

2021-01-11 Thread Dalibor Topic
On Fri, 8 Jan 2021 04:56:47 GMT, liach wrote: > Fixes the bug where receiver type is omitted in generated Javadoc when the > immediate receiver type is not annotated (but some other type within is). > > In addition, fixed the bug where receiver type for constructor is not > properly qualified

Re: RFR: 8259216: javadoc omits method receiver for any nested type annotation

2021-01-11 Thread liach
On Fri, 8 Jan 2021 18:39:21 GMT, Dalibor Topic wrote: >> Fixes the bug where receiver type is omitted in generated Javadoc when the >> immediate receiver type is not annotated (but some other type within is). >> >> In addition, fixed the bug where receiver type for constructor is not >> proper

RFR: 8259216: javadoc omits method receiver for any nested type annotation

2021-01-11 Thread liach
Fixes the bug where receiver type is omitted in generated Javadoc when the immediate receiver type is not annotated (but some other type within is). In addition, fixed the bug where receiver type for constructor is not properly qualified (without a clickable link), i.e. `OuterClass.this` vs `thi

Integrated: JDK-8258655: remove <-- NewPage --> comment from generated pages

2021-01-11 Thread Jonathan Gibbons
On Fri, 18 Dec 2020 01:16:41 GMT, Jonathan Gibbons wrote: > Small change to remove an unnecessary comment from the beginning of generated > files. I'm guessing the comment dates from way back when the doc pages were > used to generate paper books. For those that want to identify that point in

Integrated: JDK-8258659: Eliminate whitespace comments from generated pages

2021-01-11 Thread Jonathan Gibbons
On Fri, 18 Dec 2020 04:20:39 GMT, Jonathan Gibbons wrote: > Empty comments were being used to stop empty nodes being optimized away in > `HtmlTree.add`, but the empty comments caused annoying noise in the generated > docs. A better solution is to use `HtmlTree.EMPTY`, which had the right > ef

Re: RFR: JDK-8258659: Eliminate whitespace comments from generated pages [v2]

2021-01-11 Thread Jonathan Gibbons
> Empty comments were being used to stop empty nodes being optimized away in > `HtmlTree.add`, but the empty comments caused annoying noise in the generated > docs. A better solution is to use `HtmlTree.EMPTY`, which had the right > effect, without the unwanted side-effects. Jonathan Gibbons h

[jdk16] Integrated: JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

2021-01-11 Thread Jonathan Gibbons
On Wed, 23 Dec 2020 00:01:11 GMT, Jonathan Gibbons wrote: > This PR improves the diagnostic when javac is run in an image that does not > provide a service provider for DocLint. > > Instead of reporting messages about unsupported options, the following > warning will be generated: > > ` > War

Re: [jdk16] RFR: JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing [v2]

2021-01-11 Thread Jonathan Gibbons
> This PR improves the diagnostic when javac is run in an image that does not > provide a service provider for DocLint. > > Instead of reporting messages about unsupported options, the following > warning will be generated: > > ` > Warning: No service provider for doclint is available > ` > >

Re: [jdk16] RFR: JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

2021-01-11 Thread Jonathan Gibbons
On Mon, 11 Jan 2021 15:02:31 GMT, Hannes Wallnöfer wrote: >> This PR improves the diagnostic when javac is run in an image that does not >> provide a service provider for DocLint. >> >> Instead of reporting messages about unsupported options, the following >> warning will be generated: >> >>

Re: [jdk16] RFR: JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

2021-01-11 Thread Jonathan Gibbons
On Mon, 11 Jan 2021 14:58:29 GMT, Hannes Wallnöfer wrote: >> This PR improves the diagnostic when javac is run in an image that does not >> provide a service provider for DocLint. >> >> Instead of reporting messages about unsupported options, the following >> warning will be generated: >> >>

Re: RFR: JDK-8258659: Eliminate whitespace comments from generated pages

2021-01-11 Thread Hannes Wallnöfer
On Fri, 18 Dec 2020 04:20:39 GMT, Jonathan Gibbons wrote: > Empty comments were being used to stop empty nodes being optimized away in > `HtmlTree.add`, but the empty comments caused annoying noise in the generated > docs. A better solution is to use `HtmlTree.EMPTY`, which had the right > ef

Re: RFR: JDK-8258655: remove <-- NewPage --> comment from generated pages

2021-01-11 Thread Hannes Wallnöfer
On Fri, 18 Dec 2020 01:16:41 GMT, Jonathan Gibbons wrote: > Small change to remove an unnecessary comment from the beginning of generated > files. I'm guessing the comment dates from way back when the doc pages were > used to generate paper books. For those that want to identify that point in

Re: [jdk16] RFR: JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

2021-01-11 Thread Hannes Wallnöfer
On Wed, 23 Dec 2020 00:01:11 GMT, Jonathan Gibbons wrote: > This PR improves the diagnostic when javac is run in an image that does not > provide a service provider for DocLint. > > Instead of reporting messages about unsupported options, the following > warning will be generated: > > ` > War

Integrated: JDK-8250768: javac should be adapted to changes in JEP 12

2021-01-11 Thread Jan Lahoda
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (java