On Thu, 22 Jul 2021 21:08:31 GMT, Daniel D. Daugherty
wrote:
> This patch was clearly not properly tested before being integrated.
It seems that the patch was integrated without prior synchronization with the
mainline, which had diverged in the relevant areas since the patch was last
updated.
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty
wrote:
> This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464.
This pull request has now been integrated.
Changeset: 9b93d816
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/commit/9b93d816c182278427ef76
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty
wrote:
> This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464.
@jonathan-gibbons has said that he is okay with a [BACKOUT] or a ProblemListing.
The [BACKOUT] is tested and ready so I'm going with it.
-
PR: https://git.o
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty
wrote:
> This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464.
The fix for:
JDK-8249634 doclint should report implicit constructor as missing javadoc
comments
failed on every OS in Mach5 Tier1. Not just Windows. This patch was cle
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty
wrote:
> This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464.
I think I know where the problem is: a hardcoded file separator, which is
system dependent. Did the original patch for 8249634 fail on a Windows machine?
-
If there is only one test failing, I'd rather the single test be problem
listed rather than the patch being backed out.
Thanks,
-Joe
On 7/22/2021 1:57 PM, Igor Ignatyev wrote:
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty
wrote:
This reverts commit c1c404896ca2791ad348a4cf482beb2c
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty
wrote:
> This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464.
Marked as reviewed by iignatyev (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4880
On Thu, 22 Jul 2021 11:23:13 GMT, Hannes Wallnöfer wrote:
>> This change fixes a NPE in `JavadocLog` when the `DocTreePath` for an
>> inherited doc comment can't be retrieved.
>>
>> The most important change is to fix the `overriddenElement` feature in
>> `CommentHelper`. The purpose of this
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty
wrote:
> This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464.
The Mach5 Tier1 job has PASSed.
-
PR: https://git.openjdk.java.net/jdk/pull/4880
This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464.
-
Commit messages:
- Revert "8249634: doclint should report implicit constructor as missing
javadoc comments"
Changes: https://git.openjdk.java.net/jdk/pull/4880/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&
On Thu, 22 Jul 2021 11:23:13 GMT, Hannes Wallnöfer wrote:
>> This change fixes a NPE in `JavadocLog` when the `DocTreePath` for an
>> inherited doc comment can't be retrieved.
>>
>> The most important change is to fix the `overriddenElement` feature in
>> `CommentHelper`. The purpose of this
On Tue, 6 Jul 2021 17:48:48 GMT, Jonathan Gibbons wrote:
> Please review a simple update to doclint, to generate messages for the
> "effectively missing" comment on default constructors on "normal" classes
> (not enums classes or record classes.)
>
> The change does affect a bunch of tests, mo
> This change fixes a NPE in `JavadocLog` when the `DocTreePath` for an
> inherited doc comment can't be retrieved.
>
> The most important change is to fix the `overriddenElement` feature in
> `CommentHelper`. The purpose of this feature is to enable lookup of the
> `DocTreePath` or `Element`
On Thu, 22 Jul 2021 09:23:18 GMT, Pavel Rappo wrote:
>> When searching output for multiple strings it is easy to misexpress your
>> intent, which could make a failing test pass. Such cases can be caught and
>> reported to the programmer.
>>
>> For example, for this search to succeed it is suff
On Wed, 21 Jul 2021 19:59:37 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocLog.java line
>> 523:
>>
>>> 521: if (path == null || path.getTreePath() == null) {
>>> 522: return null;
>>> 523: }
>>
>> Please justify this
> This change fixes a NPE in `JavadocLog` when the `DocTreePath` for an
> inherited doc comment can't be retrieved.
>
> The most important change is to fix the `overriddenElement` feature in
> `CommentHelper`. The purpose of this feature is to enable lookup of the
> `DocTreePath` or `Element`
> When searching output for multiple strings it is easy to misexpress your
> intent, which could make a failing test pass. Such cases can be caught and
> reported to the programmer.
>
> For example, for this search to succeed it is sufficient for the output to
> consist only of the `"error: bad
17 matches
Mail list logo
