Integrated: JDK-8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments

2021-08-11 Thread Jonathan Gibbons
On Wed, 11 Aug 2021 17:38:49 GMT, Jonathan Gibbons wrote: > Please review a do-over of JDK-8249634, to report a missing doc comment when > an implicit/default constructor is used. > > The `src` code is the same as before. The previous version had missing test > files (now added), and had a t

Integrated: JDK-8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method

2021-08-11 Thread Jonathan Gibbons
On Fri, 9 Jul 2021 19:17:04 GMT, Jonathan Gibbons wrote: > Please review a simple change to the code for generating docs for JavaFX > properties, in order to suppress an inappropriate > "missing comment" warning. > > The change is to use `hasDocCommentTree` instead of `getDocCommentTree`. > >

Re: RFR: JDK-8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments

2021-08-11 Thread Joe Darcy
On Wed, 11 Aug 2021 17:38:49 GMT, Jonathan Gibbons wrote: > Please review a do-over of JDK-8249634, to report a missing doc comment when > an implicit/default constructor is used. > > The `src` code is the same as before. The previous version had missing test > files (now added), and had a t

RFR: JDK-8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments

2021-08-11 Thread Jonathan Gibbons
Please review a do-over of JDK-8249634, to report a missing doc comment when an implicit/default constructor is used. The `src` code is the same as before. The previous version had missing test files (now added), and had a test fail because an interaction with another changeset that was pushe

RFR: JDK-8272158: SoftReference related bugs under memory pressure

2021-08-11 Thread Hannes Wallnöfer
This change fixes two problems related to usage of soft references in javadoc. The one in `VisibleMemberTable` is rather trivial, it just avoids getting the softly referenced value twice, which allowed GC to clear the reference between the two calls. For the one in `CommentHelper`, I consider