> Please review a moderately simple improvement for `JavadocTester` and a
> related new test.
>
> A new `OutputChecker` class is introduced that mostly supersedes the existing
> methods to check the output generated by javadoc and the standard doclet. A
> self-imposed restriction is that no exi
On Fri, 1 Oct 2021 14:59:47 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge with upstream/master
>> - JDK-8273154: Provide a JavadocTester method for non-ove
On Wed, 20 Oct 2021 00:09:10 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 1063:
>>
>>> 1061: * Checks that there are no duplicate lines in the content.
>>> 1062: */
>>> 1063: public OutputChecker checkUnique() {
>
On Fri, 1 Oct 2021 15:19:18 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge with upstream/master
>> - JDK-8273154: Provide a JavadocTester method for non-ove
On Wed, 20 Oct 2021 00:05:53 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 1030:
>>
>>> 1028: .map(s -> "" + toShortString(s))
>>> 1029: .collect(Collectors.joining("\n")));
>>> 1030:
On Wed, 20 Oct 2021 00:04:48 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 953:
>>
>>> 951: * @param file the file
>>> 952: */
>>> 953: public OutputChecker(String file) {
>>
>> Given JDK-8274172, consider using j
On Wed, 20 Oct 2021 00:01:46 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 938:
>>
>>> 936: return new Range(start, end);
>>> 937: }
>>> 938: boolean overlaps(Range other) {
>>
>> The `overlaps` meth
On Wed, 20 Oct 2021 00:03:11 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 923:
>>
>>> 921: * Configuration can be done with a series of chained method calls.
>>> 922: * Checks can be specified as either literal strings or regular
On Wed, 20 Oct 2021 00:10:40 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 540:
>>
>>> 538: checking("checkOutput");
>>> 539: // Find string in file's contents
>>> 540: boolean isFound = findString(fileSt
On Wed, 20 Oct 2021 10:18:24 GMT, Hannes Wallnöfer wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/LinkChecker.java line 354:
>>
>>> 352: void addReference(String name, Path from, int line) {
>>> 353: if (checked) {
>>> 354: if (name != null && !name.i
On Wed, 20 Oct 2021 10:15:39 GMT, Hannes Wallnöfer wrote:
>> test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java line
>> 214:
>>
>>> 212: >> class="element-name">case%s()
>>> 213:
>>> 214: >> class="snippe
> Please review a change to add a copy-to-clipboard feature to snippets. I took
> special care to make the feature usable on mobile devices. Sample output can
> be viewed and tested here:
>
> http://cr.openjdk.java.net/~hannesw/8275406/api.00/java.base/java/lang/Throwable.html#printStackTrace()
On Tue, 19 Oct 2021 16:14:37 GMT, Pavel Rappo wrote:
>> Please review a change to add a copy-to-clipboard feature to snippets. I
>> took special care to make the feature usable on mobile devices. Sample
>> output can be viewed and tested here:
>>
>> http://cr.openjdk.java.net/~hannesw/8275406/
On Tue, 19 Oct 2021 23:50:56 GMT, Jonathan Gibbons wrote:
> Approved, but
>
> The PR is about providing comments, and (with one typo) they're OK. But it
> does seem like some names could be moved into specific existing or new
> sections other than just "Miscellaneous". But, I guess I'm OK
On Thu, 14 Oct 2021 08:39:01 GMT, Hannes Wallnöfer wrote:
> Please review this simple change to add doc comments to the so far
> undocumented `HtmlStyle` constants. I also removed one more unused constant
> (memberNameLabel).
This pull request has now been integrated.
Changeset: 5454a767
Auth
> Please review this simple change to add doc comments to the so far
> undocumented `HtmlStyle` constants. I also removed one more unused constant
> (memberNameLabel).
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Address PR c
On Tue, 19 Oct 2021 23:37:17 GMT, Jonathan Gibbons wrote:
>> Please review this simple change to add doc comments to the so far
>> undocumented `HtmlStyle` constants. I also removed one more unused constant
>> (memberNameLabel).
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/for
17 matches
Mail list logo
