Re: RFR: JDK-8275788: Create code element with suitable attributes for code snippets [v5]

2021-11-02 Thread Hannes Wallnöfer
On Tue, 2 Nov 2021 18:54:48 GMT, Hannes Wallnöfer wrote: >> Please review a change to add a nested `` element for snippet tags as >> well as HTML attributes for the snippet's `id` and `lang` attributes. The >> change is quite simple, I did however encounter some gotchas. Below is a >> short li

Re: RFR: JDK-8275788: Create code element with suitable attributes for code snippets [v5]

2021-11-02 Thread Hannes Wallnöfer
> Please review a change to add a nested `` element for snippet tags as > well as HTML attributes for the snippet's `id` and `lang` attributes. The > change is quite simple, I did however encounter some gotchas. Below is a > short list of notes to explain some aspects of the change. > > - Both

Re: RFR: JDK-8275788: Create code element with suitable attributes for code snippets [v4]

2021-11-02 Thread Hannes Wallnöfer
> Please review a change to add a nested `` element for snippet tags as > well as HTML attributes for the snippet's `id` and `lang` attributes. The > change is quite simple, I did however encounter some gotchas. Below is a > short list of notes to explain some aspects of the change. > > - Both

Integrated: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-11-02 Thread Hannes Wallnöfer
On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote: > Please review a change to add a copy-to-clipboard feature to snippets. I took > special care to make the feature usable on mobile devices. Sample output can > be viewed and tested here: > > http://cr.openjdk.java.net/~hannesw/8275406/