Integrated: JDK-8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java fails after JDK-8280738

2022-01-31 Thread Jonathan Gibbons
On Tue, 1 Feb 2022 00:22:31 GMT, Jonathan Gibbons wrote: > Remove review a trivial fix to remove a workaround for the absence of some > CSS classes in HtmlStyle.java. Those snippet-related classes have now been > added, and the workaround needs to be removed. This pull request has now been int

Re: RFR: JDK-8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java fails after JDK-8280738

2022-01-31 Thread Joe Darcy
On Tue, 1 Feb 2022 00:22:31 GMT, Jonathan Gibbons wrote: > Remove review a trivial fix to remove a workaround for the absence of some > CSS classes in HtmlStyle.java. Those snippet-related classes have now been > added, and the workaround needs to be removed. Marked as reviewed by darcy (Revie

RFR: JDK-8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java fails after JDK-8280738

2022-01-31 Thread Jonathan Gibbons
Remove review a trivial fix to remove a workaround for the absence of some CSS classes in HtmlStyle.java. Those snippet-related classes have now been added, and the workaround needs to be removed. - Commit messages: - JDK-8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/Che

Integrated: JDK-8280534: Enable compile-time doclint reference checking

2022-01-31 Thread Joe Darcy
On Wed, 26 Jan 2022 20:05:07 GMT, Joe Darcy wrote: > The changes in this PR on top of the out-for-review changes in > https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint > checking to be enabled in all JDK modules. > > Typically, a @SuppressWarnings("doclint:refernce") annota

Re: RFR: JDK-8280534: Enable compile-time doclint reference checking [v3]

2022-01-31 Thread Joe Darcy
> The changes in this PR on top of the out-for-review changes in > https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint > checking to be enabled in all JDK modules. > > Typically, a @SuppressWarnings("doclint:refernce") annotation is added to > declaration with javadoc blocks t

Integrated: JDK-8272984: javadoc support for reproducible builds

2022-01-31 Thread Jonathan Gibbons
On Fri, 21 Jan 2022 00:11:21 GMT, Jonathan Gibbons wrote: > Please review a javadoc update to support a new `--date` option to support > reproducible builds. > > This pull request supersedes https://github.com/openjdk/jdk/pull/6905. In > that PR, the `SOURCE_DATE_EPOCH` environment variable wa

Integrated: JDK-8280488: doclint reference checks withstand warning suppression

2022-01-31 Thread Jonathan Gibbons
On Wed, 26 Jan 2022 02:20:24 GMT, Jonathan Gibbons wrote: > Please review a small modification to the way that bad references are > reported by DocLint. > > A new "mode" is introduced, `strictReferenceChecks`. > > If the mode is _not_ set, references that explicitly include a module name >

Integrated: JDK-8280738: Minor cleanup for HtmlStyle

2022-01-31 Thread Jonathan Gibbons
On Wed, 26 Jan 2022 18:45:15 GMT, Jonathan Gibbons wrote: > Please review a simple update to reorder some members of the enum > `HtmlStyle`, and to make some minor updates to the comments. > > This is to facilitate automated extraction of information into an upcoming > new spec for the output

Re: RFR: JDK-8280738: Minor cleanup for HtmlStyle [v2]

2022-01-31 Thread Jonathan Gibbons
> Please review a simple update to reorder some members of the enum > `HtmlStyle`, and to make some minor updates to the comments. > > This is to facilitate automated extraction of information into an upcoming > new spec for the output from the standard doclet. Jonathan Gibbons has updated the

Re: RFR: JDK-8280738: Minor cleanup for HtmlStyle

2022-01-31 Thread Jonathan Gibbons
On Thu, 27 Jan 2022 10:22:20 GMT, Hannes Wallnöfer wrote: >> Please review a simple update to reorder some members of the enum >> `HtmlStyle`, and to make some minor updates to the comments. >> >> This is to facilitate automated extraction of information into an upcoming >> new spec for the ou