Re: RFR: JDK-8248863: Add search landing page to API documentation [v3]

2022-04-20 Thread liach
On Tue, 19 Apr 2022 21:04:04 GMT, Hannes Wallnöfer wrote: >> This is the second of two PRs to enhance JavaDoc search, it is based on the >> first one (#8185). >> >> It adds a standalone search page (search.html) along with its own script >> file (search-page.js). This PR is very similar to the

Re: RFR: 8284908: Refine diagnostic positions for DCErroneous [v3]

2022-04-20 Thread Pavel Rappo
> Before: > > Standard Doclet version 18+36-2087 > Building tree for all the packages and classes... > Generating /tmp/whatever/ExampleDiagnostics.html... > ExampleDiagnostics.java:5: error: unexpected content > * {@docRoot a} >^ > ExampleDiagnostics.java:11: error: unexpected content

Re: RFR: 8284908: Refine diagnostic positions for DCErroneous [v2]

2022-04-20 Thread Pavel Rappo
On Wed, 20 Apr 2022 21:45:51 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > test/langtools/tools/javac/doctree/DocCommentTester.java line 732: > >> 730: v

Re: RFR: 8284908: Refine diagnostic positions for DCErroneous [v2]

2022-04-20 Thread Pavel Rappo
> Before: > > Standard Doclet version 18+36-2087 > Building tree for all the packages and classes... > Generating /tmp/whatever/ExampleDiagnostics.html... > ExampleDiagnostics.java:5: error: unexpected content > * {@docRoot a} >^ > ExampleDiagnostics.java:11: error: unexpected content

Re: RFR: 8284908: Refine diagnostic positions for DCErroneous

2022-04-20 Thread Jonathan Gibbons
On Fri, 15 Apr 2022 16:58:55 GMT, Pavel Rappo wrote: > Before: > > Standard Doclet version 18+36-2087 > Building tree for all the packages and classes... > Generating /tmp/whatever/ExampleDiagnostics.html... > ExampleDiagnostics.java:5: error: unexpected content > * {@docRoot a} >^

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-20 Thread Hannes Wallnöfer
On Wed, 13 Apr 2022 21:27:30 GMT, liach wrote: > 1. Seems the result list will automatically scroll down when the mouse > hovers over, which feels weird. > > 2. When an arbitrary string is typed in and enter is pressed, it > navigates to the best match, even though it may not be an acc