On Thu, 5 May 2022 00:18:56 GMT, Jonathan Gibbons wrote:
> Please review some cleanup updates to address issues reported by an IDE.
>
> The seeds for the change were a series of redundant casts, that have now all
> been removed. Various other warnings and suggestions were made by the IDE
> fo
> Please review some cleanup updates to address issues reported by an IDE.
>
> The seeds for the change were a series of redundant casts, that have now all
> been removed. Various other warnings and suggestions were made by the IDE
> for the affected files. There were a number of places with re
On Thu, 5 May 2022 23:51:59 GMT, liach wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ClassUseMapper.java
>
On Thu, 5 May 2022 17:20:25 GMT, Jonathan Gibbons wrote:
>> Please review some cleanup updates to address issues reported by an IDE.
>>
>> The seeds for the change were a series of redundant casts, that have now all
>> been removed. Various other warnings and suggestions were made by the IDE
On Thu, 5 May 2022 17:20:25 GMT, Jonathan Gibbons wrote:
>> Please review some cleanup updates to address issues reported by an IDE.
>>
>> The seeds for the change were a series of redundant casts, that have now all
>> been removed. Various other warnings and suggestions were made by the IDE
> Please review some cleanup updates to address issues reported by an IDE.
>
> The seeds for the change were a series of redundant casts, that have now all
> been removed. Various other warnings and suggestions were made by the IDE
> for the affected files. There were a number of places with re
On Thu, 5 May 2022 14:43:52 GMT, Jonathan Gibbons wrote:
>> Correction: `switch` _expressions_ in this case.
>
> will examine; I was (generally) trying not to override IDE formatting.
fixed
-
PR: https://git.openjdk.java.net/jdk/pull/8543
On Thu, 5 May 2022 14:43:37 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java
>> line 1063:
>>
>>> 1061: if (enclosing != null) {
>>> 1062: return switch (enclosing.getKind()) {
>>> 1063:
> This is the second of two PRs to enhance JavaDoc search, it is based on the
> first one (#8185).
>
> It adds a standalone search page (search.html) along with its own script file
> (search-page.js). This PR is very similar to the last prototype I uploaded
> and demoed, the changes are mostly
On Thu, 5 May 2022 10:09:32 GMT, Pavel Rappo wrote:
>> Please review some cleanup updates to address issues reported by an IDE.
>>
>> The seeds for the change were a series of redundant casts, that have now all
>> been removed. Various other warnings and suggestions were made by the IDE
>> fo
On Tue, 19 Apr 2022 21:04:04 GMT, Hannes Wallnöfer wrote:
>> This is the second of two PRs to enhance JavaDoc search, it is based on the
>> first one (#8185).
>>
>> It adds a standalone search page (search.html) along with its own script
>> file (search-page.js). This PR is very similar to the
On Mon, 11 Apr 2022 17:06:05 GMT, Hannes Wallnöfer wrote:
> Please review the first of two PRs to enhance JavaDoc search.
>
> This one focuses on the existing search script, to which it adds the feature
> to search for multiple terms. It also improves the implementation of
> case-sensitive se
On Wed, 4 May 2022 20:33:28 GMT, Jonathan Gibbons wrote:
> Approved, with a grammar suggestion.
Thanks for the thumbs up, I added a commit with the suggested comma.
-
PR: https://git.openjdk.java.net/jdk/pull/8185
> Please review the first of two PRs to enhance JavaDoc search.
>
> This one focuses on the existing search script, to which it adds the feature
> to search for multiple terms. It also improves the implementation of
> case-sensitive search as well as rating of matches and provides some general
On Thu, 5 May 2022 10:38:43 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java
>> line 1206:
>>
>>> 1204: AccessKind accessValue = null;
>>> 1205: for (ElementKind kind : ALLOWED_KINDS) {
>>> 1206: access
On Thu, 5 May 2022 10:17:16 GMT, Pavel Rappo wrote:
>> Please review some cleanup updates to address issues reported by an IDE.
>>
>> The seeds for the change were a series of redundant casts, that have now all
>> been removed. Various other warnings and suggestions were made by the IDE
>> fo
On Thu, 5 May 2022 09:58:13 GMT, Pavel Rappo wrote:
>> Please review some cleanup updates to address issues reported by an IDE.
>>
>> The seeds for the change were a series of redundant casts, that have now all
>> been removed. Various other warnings and suggestions were made by the IDE
>> fo
On Thu, 5 May 2022 10:30:17 GMT, Pavel Rappo wrote:
>> Please review some cleanup updates to address issues reported by an IDE.
>>
>> The seeds for the change were a series of redundant casts, that have now all
>> been removed. Various other warnings and suggestions were made by the IDE
>> fo
On Thu, 5 May 2022 00:18:56 GMT, Jonathan Gibbons wrote:
> Please review some cleanup updates to address issues reported by an IDE.
>
> The seeds for the change were a series of redundant casts, that have now all
> been removed. Various other warnings and suggestions were made by the IDE
> fo
19 matches
Mail list logo
