On Wed, 10 Nov 2021 07:10:53 GMT, Andrey Turbanov wrote:
> There are couple of places where manual cycle is used to check if `String`
> contains non-whitespaces characters.
> Since Java 11 we have String.isBlank() which could be used instead.
This pull request has now been i
On Wed, 10 Nov 2021 18:41:37 GMT, Jonathan Gibbons wrote:
>> There are couple of places where manual cycle is used to check if `String`
>> contains non-whitespaces characters.
>> Since Java 11 we have String.isBlank() which could be used instead.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/int
There are couple of places where manual cycle is used to check if `String`
contains non-whitespaces characters.
Since Java 11 we have String.isBlank() which could be used instead.
-
Commit messages:
- [PATCH] Use String.isBlank in jdk.javadoc
- [PATCH] Remove redundant boxing in jd
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
> Affected modules: jdk.javadoc, jdk.jcmd, jdk.jconsole
This pull request has now been integrated.
Changeset: 5ffb5d10
Author:
On Wed, 22 Sep 2021 18:25:53 GMT, Andrey Turbanov
wrote:
> There are several redundant casts, caused by fact, that related declared
> variable has too weak type.
> We can change declaration type and remove redundant cast. It makes code more
> clear and easier to read.
>
>
There are several redundant casts, caused by fact, that related declared
variable has too weak type.
We can change declaration type and remove redundant cast. It makes code more
clear and easier to read.
Found by IntelliJ IDEA inspection 'Too weak variable type leads to unnecessary
cast'
-
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272992: Replace usages of Collections.sort with List.sort call in jdk.*
m
On Sat, 25 Sep 2021 11:15:20 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
&g
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272992: Replace usages of Collections.sort with List.sort call in jdk.*
m
On Tue, 14 Sep 2021 19:02:10 GMT, Chris Plummer wrote:
>Make sure you run the tests in test/hotspot/jtreg/serviceability/sa/ and
>test/jdk/sun/tools/jhsdb/
Checked. All fine:
==
Test summary
==
TEST
On Mon, 13 Sep 2021 17:58:02 GMT, Rémi Forax wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8272992: Replace usages of Collections.sort with List.sort call in jdk.*
>> modules
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272992: Replace usages of Collections.sort with List.sort call in jdk.*
m
On Mon, 13 Sep 2021 22:11:24 GMT, liach
wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RepositoryFiles.java
>> line 215:
>>
>>> 213: pathLookup.remove(remove);
>>> 214: }
>>> 215: added.sort((p1, p2) -> p1.compareTo(p2));
>>
>> 'added.sor
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Yeah. I think it's better to leave it to another PR/issue. To make this easier
to review/validate.
-
Collections.sort is just a wrapper, so it is better to use an instance method
directly.
-
Commit messages:
- [PATCH] Replace usages of Collections.sort with List.sort call in jdk.*
modules
Changes: https://git.openjdk.java.net/jdk/pull/5230/files
Webrev: https://webrevs.openjdk.j
16 matches
Mail list logo
