Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint

On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote: > Please review a moderate change to enable (most) doclet warnings even if > doclint is enabled. > > Since the introduction of doclint, there was some (small) overlap between the > small set of warnings generated by the doclet and the ne

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote: > Should I change the JBS issue title to match the PR title, or is it preferred > for the PR title to change? They need to match. You can either do it manually, or change the title to just the bug number and the bot will change it for you.

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote: > Please review a change to add a copy-to-clipboard feature to snippets. I took > special care to make the feature usable on mobile devices. Sample output can > be viewed and tested here: > > http://cr.openjdk.java.net/~hannesw/8275406/

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote: > This is an initial PR for expanded lint warnings done under two bugs: > > 8202056: Expand serial warning to check for bad overloads of serial-related > methods and ineffectual fields > 8160675: Issue lint warning for non-serializable non-tran

[jdk17] Integrated: 8259848: Interim javadoc build does not support platform links

On Wed, 7 Jul 2021 19:02:04 GMT, Erik Joelsson wrote: > This patch adds copying of element-list files generated for jdk.javadoc to > the interim langtools version of jdk.javadoc. I'm also refactoring the > jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infr

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links [v2]

view of this file. Rebuilding > should now work better with the various clean targets and any problems with > the generation tool will be captured in separate log files, along with the > command lines. > > @hns Can you verify that this solves the problem you reported? Erik Joels

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

On Fri, 9 Jul 2021 20:13:56 GMT, Jonathan Gibbons wrote: >> This patch adds copying of element-list files generated for jdk.javadoc to >> the interim langtools version of jdk.javadoc. I'm also refactoring the >> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra >> stan

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

On Mon, 12 Jul 2021 11:10:26 GMT, Magnus Ihse Bursie wrote: >> This patch adds copying of element-list files generated for jdk.javadoc to >> the interim langtools version of jdk.javadoc. I'm also refactoring the >> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra >> s

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

On Wed, 7 Jul 2021 19:02:04 GMT, Erik Joelsson wrote: > This patch adds copying of element-list files generated for jdk.javadoc to > the interim langtools version of jdk.javadoc. I'm also refactoring the > jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infr

[jdk17] RFR: 8259848: Interim javadoc build does not support platform links

This patch adds copying of element-list files generated for jdk.javadoc to the interim langtools version of jdk.javadoc. I'm also refactoring the jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra standards as this was missed in the original review of this file. Rebuildin

Re: RFR: 8268299: jvms tag produces incorrect URL

On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > > https://docs.oracle.com/javase/s

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

On Fri, 28 May 2021 08:19:33 GMT, Hannes Wallnöfer wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are relativel

Re: RFR: JDK-8263468: New page for "recent" new API

On Thu, 27 May 2021 13:28:33 GMT, Erik Joelsson wrote: >> I don't have a solution for this problem. AFAIK there are a few things that >> have to be "bumped" manually between releases, and this would be yet >> another. Obviously not a great solution. > >

Re: RFR: JDK-8263468: New page for "recent" new API

On Thu, 27 May 2021 13:05:27 GMT, Hannes Wallnöfer wrote: >> make/Docs.gmk line 336: >> >>> 334: >>> 335: # Add summary pages for new/deprecated APIs in recent releases >>> 336: $1_OPTIONS += --since 12,13,14,15,16,17 --since-label "New API since >>> JDK 11" >> >> How do you expect this t

Re: RFR: JDK-8263468: New page for "recent" new API

On Wed, 26 May 2021 16:02:29 GMT, Hannes Wallnöfer wrote: > This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively min

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview)

On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote: > This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/j

Re: [jdk16] RFR: 8258378: Final nroff manpage update for JDK 16

On Mon, 1 Feb 2021 11:09:25 GMT, Magnus Ihse Bursie wrote: > Before RC phase we need to ensure we have the final set of manpage updates > published in OpenJDK. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/142

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec)

On Thu, 22 Oct 2020 02:40:44 GMT, Jonathan Gibbons wrote: > This introduces support for a new `@spec` tag that can be used as either an > inline tag or as a block tag. It is used to identify references to external > specifications, in such a way that the references can be collected together >

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac un

Re: RFR: 8216497: javadoc should auto-link to platform classes

On Tue, 15 Sep 2020 09:10:54 GMT, Hannes Wallnöfer wrote: > This pull request is identical with the RFR previously sent for the Mercurial > repository: > > https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html > > I'm copy-pasting the comments from the original RFR below.

Re: RFR: 8199705: Docs.gmk needs to be updated to remove the -html5 option

Looks good. /Erik On 2018-03-21 21:36, Bhavesh Patel wrote: Hi,     This is a simple fix to Docs.gmk. A fix for JDK-8182765 was pushed recently to javadoc enabling it to generate HTML 5 output by default. This makes the "-html5" option, de

Re: RFR: 8195795: Organize javadoc output files by module/package, not just package

Build change looks good to me. /Erik On 2018-02-02 13:42, Jonathan Gibbons wrote: Please review changes, including a couple of small build changes, to reorganize the generated documentation into per-module directories. Build folk: the changes are just to move the generated module graph imag

Re: Request Review JDK-8182492: docs bundle needs legal notices for 3rd party libraries distributed for javadoc search

Looks good to me. /Erik On 2017-06-19 19:17, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182492/webrev.00/ JDK docs build enables javadoc search that distributes jquery and jszip. The docs bundle needs to include legal notices for these 3rd party libraries. In additio

Re: RFR: 8154399, 8159096, export packages containing standard javadoc doclet

Looks fine. /Erik On 2016-06-16 19:28, Jonathan Gibbons wrote: Please review this simple fix for two related aspects of the same problem: Export the "standard doclet" used by javadoc, such that it is possible to derive alternative doclets, either by delegation or subtyping. In JDK 9, javad

Re: RFR: JDK-8041487: Fix proper dependencies for correct incremental build of javadocs

(adding javadoc-dev) On 2014-04-22 15:29, Erik Joelsson wrote: (reposting with correct subject) On 2014-04-22 15:28, Erik Joelsson wrote: I recently had to work with make/Javadoc.gmk and felt that it needed some attention. This patch makes it behave correctly for incremental builds and