Re: RFR: 8271161: [BACKOUT] JDK-8249634 doclint should report implicit constructor as missing javadoc comments

2021-07-22 Thread Igor Ignatyev
On Thu, 22 Jul 2021 20:27:38 GMT, Daniel D. Daugherty wrote: > This reverts commit c1c404896ca2791ad348a4cf482beb2c2ad98464. Marked as reviewed by iignatyev (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4880

Re: RFR: 8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17

2020-12-10 Thread Igor Ignatyev
On Thu, 10 Dec 2020 23:32:43 GMT, Xin Liu wrote: > This commit seems not to pass your workflow. > https://github.com/iignatev/jdk/actions/runs/413640509 thanks for letting me know, the failures you linked to are b/c of [8258054](https://bugs.openjdk.java.net/browse/JDK-8258054) which got fixed

Integrated: 8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17

2020-12-10 Thread Igor Ignatyev
On Thu, 10 Dec 2020 18:07:32 GMT, Igor Ignatyev wrote: > Hi all, > > could you pleaes review this small and trivial fix for > `jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java` test? the test > faled to find "https://download.java.net/java/early_access/jdk16/&

Re: RFR: 8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17

2020-12-10 Thread Igor Ignatyev
On Thu, 10 Dec 2020 20:18:26 GMT, Jesper Wilhelmsson wrote: >> Hi all, >> >> could you pleaes review this small and trivial fix for >> `jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java` test? the test >> faled to find "https://download.java.net/java/early_access/jdk16/"; string >>

RFR: 8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17

2020-12-10 Thread Igor Ignatyev
Hi all, could you pleaes review this small and trivial fix for `jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java` test? the test faled to find "https://download.java.net/java/early_access/jdk16/"; string after we switched to jdk17, the patch is basically `s/jdk16/jdk17/g`. testing: