Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by iris (Reviewer). --

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class

On Fri, 29 Apr 2022 00:29:50 GMT, Jonathan Gibbons wrote: > Please review some localized cleanup for the doclint Checker class, primarily > focused on upgrading to the use of "enhanced `switch`" > > The output of one test was changed because of some improvements in one switch > statement to el

Re: RFR: JDK-8285496: DocLint does not check for missing `@param` tags for type parameters on classes and interfaces

On Thu, 28 Apr 2022 22:32:59 GMT, Jonathan Gibbons wrote: > Please review a trivial update for doclint, to check for `@param` tags for > type parameters of classes and interfaces. > > The bug was discovered recently, while making an update for record > components, but this part of the fix was

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice tidy of the code. Is there anything that can be done to prevent re-introduction of this trivial problem? Perhaps a new S

Re: RFR: JDK-8280534: Enable compile-time doclint reference checking [v2]

On Fri, 28 Jan 2022 02:15:59 GMT, Joe Darcy wrote: >> The changes in this PR on top of the out-for-review changes in >> https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint >> checking to be enabled in all JDK modules. >> >> Typically, a @SuppressWarnings("doclint:refernce") a

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Marked as reviewed by iris (Reviewer)

Re: RFR: 8273609: Fix trivial doc typos in the compiler area

On Fri, 10 Sep 2021 17:39:44 GMT, Pavel Rappo wrote: > 8273609: Fix trivial doc typos in the compiler area Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5471

Re: RFR: JDK-8271227: Missing `{@code }` in com.sun.source.*

On Mon, 16 Aug 2021 22:37:25 GMT, Jonathan Gibbons wrote: > Please review a simple `noreg-doc` update to files in the `com.sun.source.*` > API, to enclose type names in the descriptions in doc comments with `{@code > }`. > > Apart from fixing one typo, the changes are all formatting changes,

Re: [jdk17] RFR: JDK-8270872: Final nroff manpage update for JDK 17

On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote: > Please review a semi-automatic update of the nroff man pages from the > upstream files. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/303

Re: RFR: 8268299: jvms tag produces incorrect URL

On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > > https://docs.oracle.com/javase/s

Re: RFR: JDK-8266856 Make element void [v3]

On Thu, 20 May 2021 15:23:40 GMT, Jonathan Gibbons wrote: >> Please review a simple fix to treat `wbr` as a void element. > > Jonathan Gibbons has updated the pull request incrementally with one > additional commit since the last revision: > > update test Marked as reviewed by iris (Reviewer

Re: RFR: JDK-8266856 Make element void

On Tue, 18 May 2021 17:15:56 GMT, Jonathan Gibbons wrote: > Please review a simple fix to treat `war` as a void element. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4098

Re: RFR: JDK-8267187: Remove deprecated constructor for Log

On Fri, 14 May 2021 20:49:35 GMT, Jonathan Gibbons wrote: > In the course of other work, I came across this deprecated constructor in Log > which just existed for a public entry point in javadoc which has already been > removed. > > There is one remaining use in javadoc, which can be changed t

Re: RFR: JDK-8262421: doclint warnings in jdk.compiler module

On Thu, 25 Feb 2021 21:37:01 GMT, Jonathan Gibbons wrote: > Please review this doc fix to provide a couple of missing `@param` tags Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2731

Re: [jdk16] RFR: JDK-8258916: javac/doclint reports broken HTML on multiline mailto links

On Thu, 24 Dec 2020 02:04:06 GMT, Jonathan Gibbons wrote: > Please review a trivial fix to correctly handle '@' inside the value of an > HTML attribute. > The fix is simply to cancel the `newline` flag that is set when a newline has > been read. Marked as reviewed by iris (Reviewer). ---

RE: RFR: JDK-8163991: Fix license and copyright headers under test/jdk/javadoc/ and test/tools/javac/

Hi, Sandeep. > Bug: https://bugs.openjdk.java.net/browse/JDK-8163991 > Webrev: > http://cr.openjdk.java.net/~shurailine/8163991/webrev.00/langtools.patch These changes all look reasonable to me. Thanks, Iris