On Fri, 4 Jun 2021 09:01:27 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/je
On Tue, 1 Jun 2021 07:50:49 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/je
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/j
On Tue, 4 May 2021 20:35:45 GMT, Maurizio Cimadamore
wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote:
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
> http://cr.openjdk.java.net/~gbierman/jep406/j
On Thu, 22 Apr 2021 14:35:29 GMT, Ian Graves wrote:
> Converting use of `Collectors.toList()` to `Stream.toList()` where
> appropriate. Per
> [JDK-8260559](https://bugs.openjdk.java.net/browse/JDK-8260559).
Looks good!
-
Marked as reviewed by mcimadamore (Reviewer).
PR: https://
On Wed, 3 Feb 2021 13:26:25 GMT, Jan Lahoda wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java line 167:
>>
>>> 165: /** Flag for synthesized default constructors of anonymous classes.
>>> 166: */
>>> 167: public static final int ANONCONSTR = 1<<27;
>>
>
On Wed, 3 Feb 2021 10:51:28 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing merge tags are noted on the review - thanks!
>
> Good experiment! I don&#x
On Tue, 2 Feb 2021 16:28:01 GMT, Jan Lahoda wrote:
>> [This is a GitHub copy of:
>> https://mail.openjdk.java.net/pipermail/compiler-dev/2020-March/014389.html ]
>>
>> Currently, (com.sun.tools.javac.code.)Symbol/s have a long field
>> "flags_field", which holds various one-bit information ("F
On Tue, 20 Oct 2020 12:15:23 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc
>> behavior to more closely adhere to JEP 12.
>> The notable changes are:
>>
>> * adding support for Preview APIs (ja
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote:
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc
> behavior to more closely adhere to JEP 12.
> The notable changes are:
>
> * adding support for Preview APIs (javac un
ons
- modified a subtest also at SealedCompilationTests, testPrinting,
that was failing on Windows
Thanks,
Vicente
[1] http://cr.openjdk.java.net/~vromero/8227046/webrev.03.delta/
On 5/25/20 6:37 AM, Maurizio Cimadamore wrote:
Hi,
changes look good, but the parser changes do not convince me
give a nice error message in several corner
case situations detected in the reviews
- more tests were added
Thanks,
Vicente
On 5/21/20 8:14 AM, Maurizio Cimadamore wrote:
Hi Vicente,
looks very good. Some comments below.
* the parser logic is clever in its use of position to apply
context-depe
Aside from Chris comments on modifiers, I think the compact record
signature looks great, and adds a lot of value (which will pay further
dividends when we add pattern matching). Well done.
Annotations also look good.
Maurizio
On 30/10/2019 23:50, Jonathan Gibbons wrote:
Please review a moder
Answering to myself here:
On 18/10/2019 13:28, Maurizio Cimadamore wrote:
One high-level gripe which is pointing at a failure of the j.l.model
API is the lack of a way to get to the canonical constructor directly;
we have this issue both in core reflection and source reflection, and
I
I went through the javadoc changes and, although I'm no javadoc expert,
they seem clean enough, to the point that I could follow the logic quite
easily.
One high-level gripe which is pointing at a failure of the j.l.model API
is the lack of a way to get to the canonical constructor directly; w
#3 is the one I prefer; it is subtle (compared to #2), offer some
benefits (as Alex said) in terms of screen estate, and, indirectly put
the search bar front and center, as it should be.
I wonder if there should be an 'up' button to hide the top bar even when
you are looking at the top part of
17 matches
Mail list logo
