On Mon, 6 Jun 2022 14:40:01 GMT, Jan Lahoda wrote:
> Adds handling of `ElementKind.RECORD` to JShell's code completion.
looks sensible to me
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/9042
On Sat, 23 Apr 2022 17:03:06 GMT, Jonathan Gibbons wrote:
> Please review a small fix to address issues with records in DocLint when
> invoked from javac. Bottom line, record components or their fields should
> never have direct documentation comments (and so the absence of comments
> should n
On Fri, 22 Apr 2022 19:10:38 GMT, Jonathan Gibbons wrote:
> Please review a moderately simple cleanup change, to eliminate using an
> exception to terminate scanning a `Tree` or `DocTree` in
> `(Doc)TreePath.getPath`.
>
> The change is to set a field with the intended result, and once that fie
On Mon, 4 Apr 2022 23:46:57 GMT, Jonathan Gibbons wrote:
> This is a redo of a recent fix, which passed all tier1 tests but broke "make
> docs".
>
> The reason for the crash was a combination of a number of factors, such that
> fixing any one (or more) would make the problem go away, making it
On Wed, 5 Jan 2022 14:37:02 GMT, Jan Lahoda wrote:
>> Currently, when javac encounters a javadoc reference, like `@see
>> PrintStream#println(int)`, will first try to find a method `println` in
>> `PrintStream` using subtyping on the argument types, which may find another
>> overload of the me
On Tue, 4 Jan 2022 17:19:44 GMT, Jan Lahoda wrote:
> Currently, when javac encounters a javadoc reference, like `@see
> PrintStream#println(int)`, will first try to find a method `println` in
> `PrintStream` using subtyping on the argument types, which may find another
> overload of the method
On Fri, 10 Sep 2021 17:39:44 GMT, Pavel Rappo wrote:
> 8273609: Fix trivial doc typos in the compiler area
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5471
On Wed, 16 Jun 2021 07:30:09 GMT, Joel Borggrén-Franck
wrote:
>> Javac crashes in Annotate when a javadoc reference contains an annotated
>> type, since attribType expects type annotations to have been attributed.
>>
>> This proposed fix checks references at parse time to disallow annotated
>
On Mon, 14 Jun 2021 13:43:40 GMT, Hannes Wallnöfer wrote:
> This change fixes a performance regression caused by passing instances of
> `com.sun.tools.javac.util.Name` to a `html.markup.Text` object, where their
> content is accessed using`CharSequence` methods which are implemented very
> ine
On Tue, 15 Jun 2021 11:38:14 GMT, Joel Borggrén-Franck
wrote:
>> Javac crashes in Annotate when a javadoc reference contains an annotated
>> type, since attribType expects type annotations to have been attributed.
>>
>> This proposed fix checks references at parse time to disallow annotated
>
On Mon, 14 Jun 2021 13:35:35 GMT, Joel Borggrén-Franck
wrote:
> Javac crashes in Annotate when a javadoc reference contains an annotated
> type, since attribType expects type annotations to have been attributed.
>
> This proposed fix checks references at parse time to disallow annotated types
On Mon, 14 Jun 2021 18:54:39 GMT, Hannes Wallnöfer wrote:
> > just curious, what was the performance improvement after this change?
>
> Running the JavadocSteadyCompilerBench benchmark on my laptop (with other
> apps running) I get close to 5% improvement, which is similar to what I see
> in t
On Mon, 14 Jun 2021 13:43:40 GMT, Hannes Wallnöfer wrote:
> This change fixes a performance regression caused by passing instances of
> `com.sun.tools.javac.util.Name` to a `html.markup.Text` object, where their
> content is accessed using`CharSequence` methods which are implemented very
> ine
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/je
On Fri, 14 May 2021 20:49:35 GMT, Jonathan Gibbons wrote:
> In the course of other work, I came across this deprecated constructor in Log
> which just existed for a public entry point in javadoc which has already been
> removed.
>
> There is one remaining use in javadoc, which can be changed t
On Thu, 22 Apr 2021 02:21:14 GMT, Vicente Romero wrote:
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
This pull reque
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request with a new target base due t
On Wed, 19 May 2021 18:58:17 GMT, Jonathan Gibbons wrote:
>> Please review a simple fix to treat `wbr` as a void element.
>
> Jonathan Gibbons has updated the pull request incrementally with one
> additional commit since the last revision:
>
> add test
Marked as reviewed by vromero (Reviewer
On Tue, 18 May 2021 23:28:07 GMT, Jonathan Gibbons wrote:
>> test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java line 154:
>>
>>> 152: *
>>> 153: * Test current time is 10:00 at night
>>> 154: * Testtext
>>
>> this is a positive test shouldnt we have negative tests t
On Tue, 18 May 2021 17:15:56 GMT, Jonathan Gibbons wrote:
> Please review a simple fix to treat `war` as a void element.
test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java line 154:
> 152: *
> 153: * Test current time is 10:00 at night
> 154: * Testtext
this is a p
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request with a new target base due t
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request incrementally with one add
On Fri, 30 Apr 2021 03:33:57 GMT, Jonathan Gibbons wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressing indentation issues
>
> test/langtools/jdk/javadoc/doclet/testSealedT
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request with a new target base due t
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request incrementally with one add
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request with a new target base due t
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request incrementally with one add
> Please review the javadoc related changes to make sealed classes a final
> feature in Java. The patch is mostly removing preview features related code
> that is not necessary anymore in javadoc.
>
> TIA
Vicente Romero has updated the pull request with a new target base due t
On Thu, 22 Apr 2021 14:35:29 GMT, Ian Graves wrote:
> Converting use of `Collectors.toList()` to `Stream.toList()` where
> appropriate. Per
> [JDK-8260559](https://bugs.openjdk.java.net/browse/JDK-8260559).
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.o
Please review the javadoc related changes to make sealed classes a final
feature in Java. The patch is mostly removing preview features related code
that is not necessary anymore in javadoc.
TIA
-
Commit messages:
- 8265684: implement Sealed Classes as a standard feature in Java,
On Fri, 5 Mar 2021 21:44:20 GMT, Jonathan Gibbons wrote:
> Please review a moderately simple fix to improve DocLint's checking for empty
> tags, and in particular, bad use of `` as a paragraph terminator. This
> will help detect this bad usage at doclint-time, instead of later, with
> doccheck
On Wed, 3 Mar 2021 16:43:02 GMT, Jan Lahoda wrote:
> `reflowTillNow` will strip trailing spaces, but then `reflownTo` may point
> after the full content of `result`. Need to fix `reflownTo` to not point
> after the full content of `result`, otherwise a
> `StringIndexOutOfBoundsException` may o
On Mon, 19 Oct 2020 21:42:51 GMT, Jonathan Gibbons wrote:
> The patch resolves a bad merge between two recent changes.
>
> The `DocletEnvironment docEnv` parameter no longer needs to be passed around.
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote:
> 8246774: implement Record Classes as a standard feature in Java
This pull request has now been integrated.
Changeset: c17d5851
Author: Vicente Romero
URL: https://git.openjdk.java.net/jdk/commit/c17d5851
Stats: 856 li
> 8246774: implement Record Classes as a standard feature in Java
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
removing reference to unused jcod file from test
-
Changes:
- all: https://git.openjdk.java.net/
> 8246774: implement Record Classes as a standard feature in Java
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
contains 10 commits:
- Merge branch 'master' into JDK-8246774
- Merge branch 'master
> 8246774: implementing Record Classes as a standard feature in Java
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
contains ten commits:
- Merge branch 'master' into JDK-8246774
- removing unused jcod f
> 8246774: implementing Record Classes as a standard feature in Java
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
removing unused jcod file
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/290/fi
On Tue, 29 Sep 2020 20:25:27 GMT, Jonathan Gibbons wrote:
> This cleanup is primarily focussed on the WorkArounds class,
> simplifying/removing code that is no longer required.
>
> Also, simplified DocLint initialization such that it no longer needs a
> `JavacTask` and so the initiate code can
On Wed, 30 Sep 2020 08:54:14 GMT, Chris Hegarty wrote:
>> test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33:
>>
>>> 31: * jdk.compiler/com.sun.tools.javac.util
>>> 32: * @build combo.ComboTestHelper
>>> 33: * @compile LocalStaticDeclarations.java
>>
>> This, an
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Wed, 30 Sep 2020 08:54:14 GMT, Chris Hegarty wrote:
>> test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33:
>>
>>> 31: * jdk.compiler/com.sun.tools.javac.util
>>> 32: * @build combo.ComboTestHelper
>>> 33: * @compile LocalStaticDeclarations.java
>>
>> This, an
On Wed, 30 Sep 2020 00:18:17 GMT, Vicente Romero wrote:
>> The instrument tests update looks good to me.
>
> @sspitsyn thanks for the review. Please add yourself as a reviewer
@plevart interesting, but I think that I prefer to update those benchmarks in a
follow-up patch in order
On Wed, 30 Sep 2020 00:06:19 GMT, Serguei Spitsyn wrote:
>> Marked as reviewed by jlahoda (Reviewer).
>
> The instrument tests update looks good to me.
@sspitsyn thanks for the review. Please add yourself as a reviewer
-
PR: https://git.openjdk.java.net/jdk/pull/290
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Thu, 24 Sep 2020 15:45:22 GMT, Vicente Romero wrote:
>> The classfile parser changes look good to me.
>
> I have modified the `@since`: 14 -> 16
[CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
-
PR: https://git.openjdk.java.net/jdk/pull/290
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Thu, 24 Sep 2020 12:23:13 GMT, Coleen Phillimore wrote:
>> Vicente Romero has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge pull request #1 from ChrisHegarty/record-serial-tests
>>
>>
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
good catch Chris, thanks for the patch,
Vicente
On 9/22/20 5:51 AM, Chris Hegarty wrote:
On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote:
Hi Vicente,
Please file a separate subtask for the javax.lang.model changes. This helps
with the JSR 269 MR paperwork.
Thanks,
-Joe
note: I have
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Mon, 21 Sep 2020 21:53:05 GMT, Joe Darcy wrote:
>> Please review the fix for [1]. The intention of this patch is to make
>> records final removing the need to
>> use --enable-preview in order to be able to include a record declaration in
>> a source or for the VM to execute code
>> compiled
Co-authored-by: Vicente Romero
Co-authored-by: Harold Seigel
Co-authored-by: Jonathan Gibbons
Co-authored-by: Brian Goetz
Co-authored-by: Maurizio Cimadamore
Co-authored-by: Joe Darcy
Co-authored-by: Chris Hegarty
Co-authored-by: Jan Lahoda
-
Commit messages:
- 8246774
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote:
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by
On Mon, 14 Sep 2020 16:12:18 GMT, Pavel Rappo wrote:
>> Yet another cleanup change that has accumulated during my work on
>> `DocCommentParser` and other javadoc-related areas of
>> compiler.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last
On Mon, 14 Sep 2020 14:08:50 GMT, Pavel Rappo wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 290:
>>
>>> 288:
>>> 289: protected void inlineTag(ListBuffer list) {
>>> 290: assert buf[bp] == '{' : buf[bp];
>>
>> not sure that this i
On Mon, 14 Sep 2020 09:09:11 GMT, Pavel Rappo wrote:
> Yet another cleanup change that has accumulated during my work on
> `DocCommentParser` and other javadoc-related areas of
> compiler.
src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
line 290:
> 288:
> 289:
On Tue, 8 Sep 2020 16:22:34 GMT, Jan Lahoda wrote:
>> test/langtools/tools/javac/ConditionalExpressionResolvePending.java line 38:
>>
>>> 36: * @build combo.ComboTestHelper
>>> 37: * @compile ConditionalExpressionResolvePending.java
>>> 38: * @run main/othervm --enable-preview
>>> Conditiona
On Mon, 7 Sep 2020 07:58:40 GMT, Jan Lahoda wrote:
> 8250840: some tests use --enable-preview unnecessarily
just a minor change could be needed, there is no need for another round
test/langtools/tools/javac/ConditionalExpressionResolvePending.java line 38:
> 36: * @build combo.ComboTestHelper
thanks to all the reviewers, the code for sealed classes has already
been pushed to mainline.
Vicente
On 5/18/20 6:42 PM, Vicente Romero wrote:
Hi,
Please review this patch for the compiler, javadoc and
javax.lang.model support for the JEP 360 Sealed Classes (Preview). The
changes are
ion between the "sealed" token and the "class" token e.g.
sealed @foo class Bar { }
But maybe the quick fix would be to add MONKEY_AT to the set of
expected tokens after sealed/non-sealed.
Maurizio
On 22/05/2020 19:25, Vicente Romero wrote:
Hi,
Thanks Jan and Maurizio
e not
considered subclasses. The word subtypes could be more general - but
again, it is a bit imprecise, since we're talking about declarations
here, not types. I'll defer this conundrum to our spec gurus :-)
Cheers
Maurizio
On 18/05/2020 23:42, Vicente Romero wrote:
Hi,
Please
looks good,
Vicente
On 2/18/20 4:58 PM, Jonathan Gibbons wrote:
Please review a small change to add "Classpath Exception" to a file.
The file itself is not actually used in the JDK build; it is just thge
reference for a minified copy in another file.
JBS: https://bugs.openjdk.java.net/browse
forwarding to javadoc-dev
Forwarded Message
Subject:RFR: JEP 359-Records: javadoc code
Date: Thu, 17 Oct 2019 15:43:07 -0400
From: Vicente Romero
To: Amber dev ,
compiler-...@openjdk.java.net
CC: Jonathan Gibbons , Hannes Wallnoefer
Hi,
Please review
looks good,
Vicente
On 11/1/18 6:04 PM, Jonathan Gibbons wrote:
Please review a simple fix which fixes some files which did not end
with a newline character.
The changes were performed automagically by the following command:
for i in $(find test/langtools -name \*.html | xargs pcregrep -LM
68 matches
Mail list logo
