Re: Feedback on javadoc UI changes

2019-10-14 Thread Jonathan Gibbons
To give some context for all this work ... The original motivation was to fix a mostly-internal issue, such that without some internal hackery and limitations, when clicking on a link, especially on a link to earlier in the page, the target of the link could end up "under" (obscured by) the fl

Re: Feedback on javadoc UI changes

2019-10-14 Thread John Rose
On Oct 11, 2019, at 8:08 AM, Hannes Wallnöfer wrote: > > Hi Stuart, thanks for addressing these finer usability issues. > > Yes, the animated transitions can feel weird when triggered by a small > scrolling movement. The behaviour that you prefer is called sticky > positioning. I did try to u

Re: Feedback on javadoc UI changes

2019-10-11 Thread Hannes Wallnöfer
Hi Stuart, thanks for addressing these finer usability issues. Yes, the animated transitions can feel weird when triggered by a small scrolling movement. The behaviour that you prefer is called sticky positioning. I did try to use it, but wasn’t able to combine it with the requirement of making

Re: Feedback on javadoc UI changes

2019-10-10 Thread Stuart Marks
One of the things I've always liked about javadoc is that it has the feel of a static web page. Of course, it was completely static initially. As time has gone on it's become more interactive, yet the static feeling is still there. I think this is a big advantage, because it gives me (the user)

Re: Feedback on javadoc UI changes

2019-10-10 Thread Henry Jen
Prefer #3 Works on Mac with Brave and Safari with symptom Mauricio mentioned. The blue border on search is and close icon is overlapped with Brave, but that’s nit-picking. Cheers, Henry > On Oct 9, 2019, at 10:29 AM, Hannes Wallnöfer > wrote: > > The javadoc team is considering changes

Re: Feedback on javadoc UI changes

2019-10-10 Thread Alexey Ivanov
Hi Hannes, On 10/10/2019 11:39, Hannes Wallnöfer wrote: However, the whole focus grabbing is certainly a potential source of confusion/problems. Yes, I think it could be the source of confusion. In Firefox, I have the "Search for text when you start typing" option selected (it's in the Browsi

Re: Feedback on javadoc UI changes

2019-10-10 Thread Martin Desruisseaux
Proposal #3 seems a good compromise to me. Thanks for those proposals     Martin

Re: Feedback on javadoc UI changes

2019-10-10 Thread Hannes Wallnöfer
Thanks for the hint, Sergey. (Removing jdk-dev but leaving javadoc-dev recipient as this is a more technical issue.) The changes I have done should have no effect for a11y tools like screen readers. We do have an invisible „Skip navigation links“ link though that should allow skipping over nav

Re: Feedback on javadoc UI changes

2019-10-10 Thread Hannes Wallnöfer
Thanks for the feedback, Maurizio. > Am 09.10.2019 um 22:27 schrieb Maurizio Cimadamore > : > > #3 is the one I prefer; it is subtle (compared to #2), offer some benefits > (as Alex said) in terms of screen estate, and, indirectly put the search bar > front and center, as it should be. > > I

Re: Feedback on javadoc UI changes

2019-10-10 Thread Hannes Wallnöfer
Thanks for the feedback, Alex. > Am 09.10.2019 um 20:33 schrieb Alex Buckley : > > On 10/9/2019 10:29 AM, Hannes Wallnöfer wrote: > > People should remember that the search bar often contains overview > information of its own -- not on the top-level javadoc page, but on module > and class page

Re: Feedback on javadoc UI changes

2019-10-09 Thread Sergey Bylokhov
Hi, Hannes. I have one unrelated suggestion. When I fixed some a11y related bugs in the specification, I have tried to check the fix by the VoiceOver tool. And it was really hard to navigate over the search_fields/links/text by the keyboard using VoiceOver. Probably it can be improved somehow.

Re: Feedback on javadoc UI changes

2019-10-09 Thread Michel Trudeau
Good catch Alex, thank you for testing this. On Oct 9, 2019, at 11:33 AM, Alex Buckley wrote: I think #2 has a serious problem. If you scroll, and then hit any key, then the search box grabs focus -- this is useful on the many occasions when you want to search, but it means that keyboard shortc

Re: Feedback on javadoc UI changes

2019-10-09 Thread Maurizio Cimadamore
#3 is the one I prefer; it is subtle (compared to #2), offer some benefits (as Alex said) in terms of screen estate, and, indirectly put the search bar front and center, as it should be. I wonder if there should be an 'up' button to hide the top bar even when you are looking at the top part of

Re: Feedback on javadoc UI changes

2019-10-09 Thread Alex Buckley
On 10/9/2019 10:29 AM, Hannes Wallnöfer wrote: The feedback we are looking for: - What do you prefer for scrolling up and down a page? Do you find the moving parts useful or distracting? I find the motion of the top blue bar and search box distracting at the first scroll, but only in the mos

Re: Feedback on javadoc UI changes

2019-10-09 Thread Stephen Colebourne
I prefer #1, and am not a fan of disappearing page parts. Stephen On Wed, 9 Oct 2019 at 18:31, Hannes Wallnöfer wrote: > > The javadoc team is considering changes to the UI of javadoc generated pages, > specifically the behaviour of the top navigation bar and navigating to > anchors within a p

Feedback on javadoc UI changes

2019-10-09 Thread Hannes Wallnöfer
The javadoc team is considering changes to the UI of javadoc generated pages, specifically the behaviour of the top navigation bar and navigating to anchors within a page. Since this would affect all JDK users we thought it was a good idea to present/discuss the alternatives here on jdk-dev. T