Re: RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-27 Thread Hannes Wallnöfer
On Fri, 20 Nov 2020 15:00:56 GMT, Hannes Wallnöfer wrote: > This PR softens the case-sensitivity rules in Javadoc searches by including > results of case-insensitive search if a case-sensitive yields no or very few > results. > > Changes also include some restructuring of the search.js code a

Re: RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-26 Thread Jonathan Gibbons
On Thu, 26 Nov 2020 22:36:01 GMT, Jonathan Gibbons wrote: >> There is a certain amount of "two steps forward, one step back" here. >> >> Yes, this is a good fix to the regression, so approved, and maybe it was an >> embarrassing convenience that the search test was disabled for the >> IndexBui

Re: RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-26 Thread Jonathan Gibbons
On Thu, 26 Nov 2020 20:04:17 GMT, Jonathan Gibbons wrote: >> This PR softens the case-sensitivity rules in Javadoc searches by including >> results of case-insensitive search if a case-sensitive yields no or very few >> results. >> >> Changes also include some restructuring of the search.js c

Re: RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-26 Thread Pavel Rappo
When I punch in `ToolProvider` I see 3 results in JDK 15 and 2 results on this change's sample page. Advantages are unclear. [JDK 15](https://docs.oracle.com/en/java/javase/15/docs/api/index.html): Types java.util.spi.ToolProvider javax.tools.ToolProvider Members javax.tools.Tool

Re: RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-26 Thread Jonathan Gibbons
On Fri, 20 Nov 2020 15:00:56 GMT, Hannes Wallnöfer wrote: > This PR softens the case-sensitivity rules in Javadoc searches by including > results of case-insensitive search if a case-sensitive yields no or very few > results. > > Changes also include some restructuring of the search.js code a

Re: RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-26 Thread Jonathan Gibbons
Pavel, The way I read the code changes, you need to find examples of classes with the same name but in different packages.  The example that came to mind for me is `ToolProvider`. -- Jon On 11/26/20 8:51 AM, Pavel Rappo wrote: On Fri, 20 Nov 2020 15:00:56 GMT, Hannes Wallnöfer wrote: Thi

Re: RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-26 Thread Pavel Rappo
On Fri, 20 Nov 2020 15:00:56 GMT, Hannes Wallnöfer wrote: > This PR softens the case-sensitivity rules in Javadoc searches by including > results of case-insensitive search if a case-sensitive yields no or very few > results. > > Changes also include some restructuring of the search.js code a

RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-24 Thread Hannes Wallnöfer
This PR softens the case-sensitivity rules in Javadoc searches by including results of case-insensitive search if a case-sensitive yields no or very few results. Changes also include some restructuring of the search.js code along with minor changes that improve compliance with the specificatio