On Sat, 25 Sep 2021 11:23:18 GMT, Andrey Turbanov wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>> Affected modules: jdk.javadoc, jdk.jcmd, jdk.jconsole
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional co
On Sat, 25 Sep 2021 11:23:18 GMT, Andrey Turbanov wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>> Affected modules: jdk.javadoc, jdk.jcmd, jdk.jconsole
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional co
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272992: Replace usages of Collections.sort with List.sort call in jdk.*
modules
extrac
On Sat, 25 Sep 2021 11:15:20 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
>8272992: Replace u
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8272992: Replace us
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272992: Replace usages of Collections.sort with List.sort call in jdk.*
modules
extr
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8272992: Replace us
On Tue, 14 Sep 2021 19:02:10 GMT, Chris Plummer wrote:
>Make sure you run the tests in test/hotspot/jtreg/serviceability/sa/ and
>test/jdk/sun/tools/jhsdb/
Checked. All fine:
==
Test summary
==
TEST
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8272992: Replace us
On Mon, 13 Sep 2021 17:58:02 GMT, Rémi Forax wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8272992: Replace usages of Collections.sort with List.sort call in jdk.*
>> modules
>
> src/jdk.jfr/share/classes/jdk
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272992: Replace usages of Collections.sort with List.sort call in jdk.*
modules
---
On Mon, 13 Sep 2021 22:11:24 GMT, liach
wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RepositoryFiles.java
>> line 215:
>>
>>> 213: pathLookup.remove(remove);
>>> 214: }
>>> 215: added.sort((p1, p2) -> p1.compareTo(p2));
>>
>> 'added.sor
On Mon, 13 Sep 2021 17:56:14 GMT, Rémi Forax wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RepositoryFiles.java line
> 215:
>
>> 213: pathLookup.remove(remove);
>> 214
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
src/jdk.jfr/share/classes/jdk/jfr/internal/MetadataReader.java line 86:
> 84: if (Logger.shouldLog(LogTag.JFR_SYSTEM_PARSER, LogLevel.TR
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Yeah. I think it's better to leave it to another PR/issue. To make this easier
to review/validate.
-
PR: https://git.openjdk.java.
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
This looks a good change. Either as part of this PR or as a follow up I think
it is worth reviewing the comparators passed to the sort method.
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Marked as reviewed by stsypa...@github.com (no known OpenJDK username).
-
PR: https://git.openjdk.java.net/jdk/pull/5230
Collections.sort is just a wrapper, so it is better to use an instance method
directly.
-
Commit messages:
- [PATCH] Replace usages of Collections.sort with List.sort call in jdk.*
modules
Changes: https://git.openjdk.java.net/jdk/pull/5230/files
Webrev: https://webrevs.openjdk.j
18 matches
Mail list logo
