Re: RFR: JDK-8248863: Add search landing page to API documentation [v4]

2022-05-05 Thread Hannes Wallnöfer
> This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last prototype I uploaded > and demoed, the changes are mostly

Re: RFR: JDK-8248863: Add search landing page to API documentation [v3]

2022-05-05 Thread openjdk-notifier[bot]
On Tue, 19 Apr 2022 21:04:04 GMT, Hannes Wallnöfer wrote: >> This is the second of two PRs to enhance JavaDoc search, it is based on the >> first one (#8185). >> >> It adds a standalone search page (search.html) along with its own script >> file (search-page.js). This PR is very similar to the

Re: RFR: JDK-8248863: Add search landing page to API documentation [v3]

2022-05-04 Thread Jonathan Gibbons
On Tue, 19 Apr 2022 21:04:04 GMT, Hannes Wallnöfer wrote: >> This is the second of two PRs to enhance JavaDoc search, it is based on the >> first one (#8185). >> >> It adds a standalone search page (search.html) along with its own script >> file (search-page.js). This PR is very similar to the

Re: RFR: JDK-8248863: Add search landing page to API documentation [v3]

2022-04-20 Thread liach
On Tue, 19 Apr 2022 21:04:04 GMT, Hannes Wallnöfer wrote: >> This is the second of two PRs to enhance JavaDoc search, it is based on the >> first one (#8185). >> >> It adds a standalone search page (search.html) along with its own script >> file (search-page.js). This PR is very similar to the

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-20 Thread Hannes Wallnöfer
On Wed, 13 Apr 2022 21:27:30 GMT, liach wrote: > 1. Seems the result list will automatically scroll down when the mouse > hovers over, which feels weird. > > 2. When an arbitrary string is typed in and enter is pressed, it > navigates to the best match, even though it may not be an acc

Re: RFR: JDK-8248863: Add search landing page to API documentation [v3]

2022-04-19 Thread Hannes Wallnöfer
> This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last prototype I uploaded > and demoed, the changes are mostly

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-19 Thread Hannes Wallnöfer
On Tue, 19 Apr 2022 15:00:45 GMT, Hannes Wallnöfer wrote: > > ``` > > 1. Seems the result list will automatically scroll down when the mouse > > hovers over, which feels weird. > > ``` > > I think what you're referring to is a behavior of the jQuery autocomplete > component we are using. It wa

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-19 Thread Hannes Wallnöfer
On Wed, 13 Apr 2022 21:27:30 GMT, liach wrote: > User remark: > > 1. Seems the result list will automatically scroll down when the mouse > hovers over, which feels weird. I think what you're referring to is a behavior of the jQuery autocomplete component we are using. It was not modified

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-19 Thread Hannes Wallnöfer
On Wed, 13 Apr 2022 16:01:17 GMT, Hannes Wallnöfer wrote: > This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last

Re: RFR: JDK-8248863: Add search landing page to API documentation [v2]

2022-04-19 Thread Hannes Wallnöfer
> This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last prototype I uploaded > and demoed, the changes are mostly

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-13 Thread Jonathan Gibbons
On Wed, 13 Apr 2022 16:01:17 GMT, Hannes Wallnöfer wrote: > This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-13 Thread liach
On Wed, 13 Apr 2022 16:01:17 GMT, Hannes Wallnöfer wrote: > This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last

RFR: JDK-8248863: Add search landing page to API documentation

2022-04-13 Thread Hannes Wallnöfer
This is the second of two PRs to enhance JavaDoc search, it is based on the first one (#8185). It adds a standalone search page (search.html) along with its own script file (search-page.js). This PR is very similar to the last prototype I uploaded and demoed, the changes are mostly tweaks to th