On Fri, 30 Apr 2021 09:46:08 GMT, Hannes Wallnöfer wrote:
> Thanks for the review; I agree we should think about normalizing modifiers.
>
> FWIW, the JLS describes methods in final classes as merely "behaving as if
> they were final" (8.4.3.3.), so at least technically it is still the modifier
On Fri, 30 Apr 2021 03:28:20 GMT, Jonathan Gibbons wrote:
> OK, but we might want to think about the pros and cons of normalizing
> modifiers.
Thanks for the review; I agree we should think about normalizing modifiers.
FWIW, the JLS describes methods in final classes as merely "behaving as if
On Tue, 27 Apr 2021 10:29:05 GMT, Hannes Wallnöfer wrote:
>> I found that adding the `final` modifier does not add too much visual noise
>> to the documentation. I didn't find any occurrence where there were more
>> than two modifiers on a member summary (usually either `static final` or
>> `p
On Tue, 27 Apr 2021 19:00:10 GMT, Hannes Wallnöfer wrote:
> > Hi Hannes, out of curiosity - for a final class, will all members (or none)
> > appear final in the generated documentation? Or will it depend on whether a
> > redundant `final` keyword appears in the code or not? From your code
> >
On Tue, 27 Apr 2021 13:05:54 GMT, Daniel Fuchs wrote:
> Hi Hannes, out of curiosity - for a final class, will all members (or none)
> appear final in the generated documentation? Or will it depend on whether a
> redundant `final` keyword appears in the code or not? From your code changes,
> I
On Tue, 27 Apr 2021 10:29:05 GMT, Hannes Wallnöfer wrote:
>> I found that adding the `final` modifier does not add too much visual noise
>> to the documentation. I didn't find any occurrence where there were more
>> than two modifiers on a member summary (usually either `static final` or
>> `p
> I found that adding the `final` modifier does not add too much visual noise
> to the documentation. I didn't find any occurrence where there were more than
> two modifiers on a member summary (usually either `static final` or
> `protected final`).
>
> On the other hand, I do think the `final
I found that adding the `final` modifier does not add too much visual noise to
the documentation. I didn't find any occurrence where there were more than two
modifiers on a member summary (usually either `static final` or `protected
final`).
On the other hand, I do think the `final` modifier a
