Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-05-04 Thread Vikey Chen
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-05-04 Thread Ioi Lam
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-05-03 Thread Roger Riggs
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-04-12 Thread Vikey Chen
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-04-12 Thread Ioi Lam
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-04-12 Thread Vikey Chen
On Mon, 28 Mar 2022 17:11:54 GMT, Ioi Lam wrote: >> In the longer term, I think its worth considering implementing LC_ALL as an >> override. I created an enhancement request for purposes of discussion. >> [JDK-8283697](https://bugs.openjdk.java.net/browse/JDK-8283697) On macOS, >> the locale ca

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-03-29 Thread Vikey Chen
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-03-28 Thread Roger Riggs
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-28 Thread Ioi Lam
On Mon, 28 Mar 2022 13:51:17 GMT, Roger Riggs wrote: > In the longer term, I think its worth considering implementing LC_ALL as an > override. I created an enhancement request for purposes of discussion. > [JDK-8283697](https://bugs.openjdk.java.net/browse/JDK-8283697) On macOS, the > locale c

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-03-28 Thread Vikey Chen
> From the test doc of openjdk > https://openjdk.java.net/groups/build/doc/testing.html >> If your locale is non-US, some tests are likely to fail. To work around this >> you can set the locale to US. On Unix platforms simply setting LANG="en_US" >> in the environment before running tests should

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v3]

2022-03-28 Thread Vikey Chen
On Mon, 28 Mar 2022 15:46:34 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v3]

2022-03-28 Thread Vikey Chen
> From the test doc of openjdk > https://openjdk.java.net/groups/build/doc/testing.html >> If your locale is non-US, some tests are likely to fail. To work around this >> you can set the locale to US. On Unix platforms simply setting LANG="en_US" >> in the environment before running tests should

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-28 Thread Roger Riggs
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-28 Thread David Holmes
On Mon, 28 Mar 2022 07:00:18 GMT, Ioi Lam wrote: > If a test expects an English output, then it should explicitly say so when > spawning a new JVM. The problem there is knowing when that is the case. For test/hotspot/jtreg/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java the mess

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-28 Thread Ioi Lam
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-28 Thread Ioi Lam
On Mon, 28 Mar 2022 05:13:27 GMT, David Holmes wrote: > I do not think we should be trying to use JAVA_TOOL_OPTIONS to set "global" > test arguments. If setting the locale via -javaoptions does not suffice due > to the way tests spawn JVMs without passing on those arguments, then we > should d

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-27 Thread David Holmes
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-25 Thread Vikey Chen
On Thu, 24 Mar 2022 14:06:03 GMT, Roger Riggs wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-24 Thread Vikey Chen
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-24 Thread Ioi Lam
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote: >> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en >> -Duser.country=US"`, some tests still fail because of default locale, Most >> of them are langtools tests. >> >> On MacOS 12.1. > > Vikey Chen has updated the pull requ

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-24 Thread Ioi Lam
On Thu, 24 Mar 2022 16:17:05 GMT, Ioi Lam wrote: >> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en >> -Duser.country=US"`, some tests still fail because of default locale, Most >> of them are langtools tests. >> >> On MacOS 12.1. > > As I mentioned in the bug report, it's

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v2]

2022-03-24 Thread Vikey Chen
> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en > -Duser.country=US"`, some tests still fail because of default locale, Most of > them are langtools tests. > > On MacOS 12.1. Vikey Chen has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-24 Thread Vikey Chen
On Thu, 24 Mar 2022 16:17:05 GMT, Ioi Lam wrote: >> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en >> -Duser.country=US"`, some tests still fail because of default locale, Most >> of them are langtools tests. >> >> On MacOS 12.1. > > As I mentioned in the bug report, it's

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-24 Thread Vikey Chen
On Thu, 24 Mar 2022 14:06:03 GMT, Roger Riggs wrote: >> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en >> -Duser.country=US"`, some tests still fail because of default locale, Most >> of them are langtools tests. >> >> On MacOS 12.1. > > Can you look into why these tests d

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-24 Thread Ioi Lam
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote: > I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en > -Duser.country=US"`, some tests still fail because of default locale, Most of > them are langtools tests. > > On MacOS 12.1. As I mentioned in the bug report, it's not c

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-24 Thread Roger Riggs
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote: > I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en > -Duser.country=US"`, some tests still fail because of default locale, Most of > them are langtools tests. > > On MacOS 12.1. Can you look into why these tests do not fai

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-24 Thread David Holmes
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote: > I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en > -Duser.country=US"`, some tests still fail because of default locale, Most of > them are langtools tests. > > On MacOS 12.1. I think fixing this in the test library is p

Re: RFR: 8283606: Tests may fail with zh locale on MacOS

2022-03-24 Thread Vikey Chen
On Thu, 24 Mar 2022 05:15:05 GMT, David Holmes wrote: >> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en >> -Duser.country=US"`, some tests still fail because of default locale, Most >> of them are langtools tests. >> >> On MacOS 12.1. > > I have filed: > > https://bugs.op