On Wed, 27 Oct 2021 17:15:23 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright years
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriter
On Wed, 20 Oct 2021 13:46:43 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a copy-to-clipboard feature to snippets. I
>> took special care to make the feature usable on mobile devices. Sample
>> output can be viewed and tested here:
>>
>> http://cr.openjdk.java.net/~hannesw/827
On Wed, 27 Oct 2021 17:04:53 GMT, Jonathan Gibbons wrote:
>> I think this change is OK for now. We can make it more restrictive later if
>> it becomes a problem. I tried to come up with a short explanatory comment,
>> but couldn't find one I was satisfied with.
>
> While maybe uncommon and may
On Wed, 20 Oct 2021 14:41:43 GMT, Pavel Rappo wrote:
>> I think this should be ok for the general case. Linking to "#" (i.e. empty
>> fragment) is common practice for links that trigger script functions.
>
> What I mean is that the amended test will now pass for a URL which has an
> empty fragm
On Wed, 27 Oct 2021 16:59:57 GMT, Jonathan Gibbons wrote:
>> What I mean is that the amended test will now pass for a URL which has an
>> empty fragment but is not a "button".
>
> I think this change is OK for now. We can make it more restrictive later if
> it becomes a problem. I tried to com
On Fri, 22 Oct 2021 09:06:49 GMT, Pavel Rappo wrote:
>> I've traced the execution of a local jtreg run with a debugger and examined
>> the respective `jtr` file. Here is what I saw. The locale that the javadoc
>> under test uses is that of returned by java.util.Locale.getDefault(). This
>> hap
On Wed, 20 Oct 2021 14:30:04 GMT, Pavel Rappo wrote:
>> Yes, they are localized. Good question, I do believe tests are run with
>> fixed en/US locale, but I'm not absolutely sure.
>
> I've traced the execution of a local jtreg run with a debugger and examined
> the respective `jtr` file. Here i
On Wed, 20 Oct 2021 10:18:24 GMT, Hannes Wallnöfer wrote:
>> test/langtools/jdk/javadoc/lib/javadoc/tester/LinkChecker.java line 354:
>>
>>> 352: void addReference(String name, Path from, int line) {
>>> 353: if (checked) {
>>> 354: if (name != null && !name.i
On Wed, 20 Oct 2021 10:15:39 GMT, Hannes Wallnöfer wrote:
>> test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java line
>> 214:
>>
>>> 212: >> class="element-name">case%s()
>>> 213:
>>> 214: >> class="snippe
> Please review a change to add a copy-to-clipboard feature to snippets. I took
> special care to make the feature usable on mobile devices. Sample output can
> be viewed and tested here:
>
> http://cr.openjdk.java.net/~hannesw/8275406/api.00/java.base/java/lang/Throwable.html#printStackTrace()
On Tue, 19 Oct 2021 16:14:37 GMT, Pavel Rappo wrote:
>> Please review a change to add a copy-to-clipboard feature to snippets. I
>> took special care to make the feature usable on mobile devices. Sample
>> output can be viewed and tested here:
>>
>> http://cr.openjdk.java.net/~hannesw/8275406/
On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote:
> Please review a change to add a copy-to-clipboard feature to snippets. I took
> special care to make the feature usable on mobile devices. Sample output can
> be viewed and tested here:
>
> http://cr.openjdk.java.net/~hannesw/8275406/
On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote:
> Please review a change to add a copy-to-clipboard feature to snippets. I took
> special care to make the feature usable on mobile devices. Sample output can
> be viewed and tested here:
>
> http://cr.openjdk.java.net/~hannesw/8275406/
13 matches
Mail list logo
