On Wed, 3 Nov 2021 16:02:17 GMT, Pavel Rappo wrote:
>> Hannes Wallnöfer has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> test/langtools/jdk/javadoc/doclet/te
On Tue, 2 Nov 2021 18:54:48 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short li
On Wed, 3 Nov 2021 18:40:21 GMT, Pavel Rappo wrote:
> Here's what I see after your two force pushes. The discussions we started
> have become outdated and got severed, meaning that we cannot continue them
> much less mark them "Unresolved". Lines in the cumulative diff ("Files
> changed") that
On Wed, 3 Nov 2021 15:08:04 GMT, Pavel Rappo wrote:
> Here's what I see after your two force pushes. The discussions we started
> have become outdated and got severed, meaning that we cannot continue them
> much less mark them "Unresolved". Lines in the cumulative diff ("Files
> changed") that
On Tue, 2 Nov 2021 18:54:48 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short li
On Tue, 2 Nov 2021 18:54:48 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short li
On Tue, 2 Nov 2021 18:54:48 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short li
On Tue, 2 Nov 2021 18:54:48 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short li
On Tue, 2 Nov 2021 18:54:48 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short li
> Please review a change to add a nested `` element for snippet tags as
> well as HTML attributes for the snippet's `id` and `lang` attributes. The
> change is quite simple, I did however encounter some gotchas. Below is a
> short list of notes to explain some aspects of the change.
>
> - Both
> Please review a change to add a nested `` element for snippet tags as
> well as HTML attributes for the snippet's `id` and `lang` attributes. The
> change is quite simple, I did however encounter some gotchas. Below is a
> short list of notes to explain some aspects of the change.
>
> - Both
On Fri, 29 Oct 2021 15:43:02 GMT, Jonathan Gibbons wrote:
>>> > `Utils.toLowerCase` is the right way.
>>>
>>> Some parts of jdk.javadoc reach to jdk.compiler for
>>> StringUtils.toLowerCase(String). Smells like cleanup.
>>
>> Yes. javadoc is complicated.
>>
>> Architecturally, the "tool" part
On Fri, 29 Oct 2021 14:01:38 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short l
On Fri, 29 Oct 2021 15:38:52 GMT, Jonathan Gibbons wrote:
>>> `Utils.toLowerCase` is the right way.
>>
>> Some parts of jdk.javadoc reach to jdk.compiler for
>> StringUtils.toLowerCase(String). Smells like cleanup.
>
>> > `Utils.toLowerCase` is the right way.
>>
>> Some parts of jdk.javadoc re
On Fri, 29 Oct 2021 15:16:57 GMT, Pavel Rappo wrote:
> > `Utils.toLowerCase` is the right way.
>
> Some parts of jdk.javadoc reach to jdk.compiler for
> StringUtils.toLowerCase(String). Smells like cleanup.
Yes. javadoc is complicated.
Architecturally, the "tool" part of `javadoc` inherently
On Fri, 29 Oct 2021 15:09:30 GMT, Jonathan Gibbons wrote:
> `Utils.toLowerCase` is the right way.
Some parts of jdk.javadoc reach to jdk.compiler for
StringUtils.toLowerCase(String). Smells like cleanup.
-
PR: https://git.openjdk.java.net/jdk/pull/6165
On Fri, 29 Oct 2021 13:38:02 GMT, Hannes Wallnöfer wrote:
> I went with jdk.javadoc.internal.doclets.toolkit.util.Utils.toLowerCase. If
> there is an existing nearby method that solves the problem I guess we should
> use it.
`Utils.toLowerCase` is the right way.
-
PR: https://git
On Fri, 29 Oct 2021 12:39:46 GMT, Pavel Rappo wrote:
>> Separately. After b97ea5b, the CI
>> (test/langtools/tools/javac/NoStringToLower.java) complains about that
>> `switch` using String.toLowerCase without explicit locale. We have multiple
>> options here (should we clean that up in a separ
On Fri, 29 Oct 2021 09:18:48 GMT, Pavel Rappo wrote:
>> Hannes Wallnöfer has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new c
> Please review a change to add a nested `` element for snippet tags as
> well as HTML attributes for the snippet's `id` and `lang` attributes. The
> change is quite simple, I did however encounter some gotchas. Below is a
> short list of notes to explain some aspects of the change.
>
> - Both
> Please review a change to add a nested `` element for snippet tags as
> well as HTML attributes for the snippet's `id` and `lang` attributes. The
> change is quite simple, I did however encounter some gotchas. Below is a
> short list of notes to explain some aspects of the change.
>
> - Both
On Thu, 28 Oct 2021 21:02:04 GMT, Hannes Wallnöfer wrote:
> Please review a change to add a nested `` element for snippet tags as
> well as HTML attributes for the snippet's `id` and `lang` attributes. The
> change is quite simple, I did however encounter some gotchas. Below is a
> short list
On Fri, 29 Oct 2021 11:01:44 GMT, Pavel Rappo wrote:
>> Remember it's just a convenience/default mapping to create a language
>> attribute without explicitly setting it. File extensions do not change over
>> night, so I think the only risk here is missing out on some newly popular
>> language
On Fri, 29 Oct 2021 08:07:46 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SnippetTaglet.java
>> line 336:
>>
>>> 334: case ".scala", ".sc" -> "scala";
>>> 335: case ".sh"
On Thu, 28 Oct 2021 21:02:04 GMT, Hannes Wallnöfer wrote:
> Please review a change to add a nested `` element for snippet tags as
> well as HTML attributes for the snippet's `id` and `lang` attributes. The
> change is quite simple, I did however encounter some gotchas. Below is a
> short list
On Thu, 28 Oct 2021 21:49:46 GMT, Pavel Rappo wrote:
>> Please review a change to add a nested `` element for snippet tags as
>> well as HTML attributes for the snippet's `id` and `lang` attributes. The
>> change is quite simple, I did however encounter some gotchas. Below is a
>> short list o
On Thu, 28 Oct 2021 21:02:04 GMT, Hannes Wallnöfer wrote:
> Please review a change to add a nested `` element for snippet tags as
> well as HTML attributes for the snippet's `id` and `lang` attributes. The
> change is quite simple, I did however encounter some gotchas. Below is a
> short list
27 matches
Mail list logo
