Re: VisibleMemberMap.java possible performance improvements

2013-11-25 Thread Michael Simacek
Ok, so are these three items I mentioned bugs in the original implementation? And I should report each of them separately and try to fix them in the original implementation, right? Or should I propose my patch (or part of it) as a fix for them (with tests ofc)? Michael Simacek

Re: VisibleMemberMap.java possible performance improvements

2013-09-25 Thread Jonathan Gibbons
On 09/23/2013 05:36 AM, Michael Simacek wrote: Thank you for your help, Jon. I've rewritten it a bit (also had to change the Util.executableMembersEqual method to fix some issues), so now all the tests should pass and I have fixed some other bugs. Now the order of classes is the same and order

Re: VisibleMemberMap.java possible performance improvements

2013-09-25 Thread Jonathan Gibbons
On 09/23/2013 05:36 AM, Michael Simacek wrote: Thank you for your help, Jon. I've rewritten it a bit (also had to change the Util.executableMembersEqual method to fix some issues), so now all the tests should pass and I have fixed some other bugs. Now the order of classes is the same and order

Re: VisibleMemberMap.java possible performance improvements

2013-09-25 Thread Michael Simacek
Thank you for your help, Jon. I've rewritten it a bit (also had to change the Util.executableMembersEqual method to fix some issues), so now all the tests should pass and I have fixed some other bugs. Now the order of classes is the same and order of interfaces is mostly the same. I tried to get

Re: VisibleMemberMap.java possible performance improvements

2013-09-19 Thread Jonathan Gibbons
On 09/19/2013 10:46 AM, Jonathan Gibbons wrote: -- does the change affect the generated docs. ... and the answer is "yes". :-) The order of some parts of the generated docs differs before/after the patch. This is an issue which needs to be fixed. At first, I thought it was due to the use

Re: VisibleMemberMap.java possible performance improvements

2013-09-19 Thread Jonathan Gibbons
On 09/19/2013 10:46 AM, Jonathan Gibbons wrote: There are two criteria for a change like this: -- the obvious one -- do all the javadoc regression tests pass. These are the tests langtools/test/com/sun/javadoc langtools/test/tools/javadoc Two regression tests fail when the patch is

Re: VisibleMemberMap.java possible performance improvements

2013-09-19 Thread Jonathan Gibbons
On 09/19/2013 11:02 AM, Jonathan Gibbons wrote: On 09/19/2013 10:00 AM, Michael Simacek wrote: Hi, I thought about improving performance of the default doclet implementation a bit. According to profiler results, most of the CPU time is spent in constructing the member map in VisibleMemberMap.

Re: VisibleMemberMap.java possible performance improvements

2013-09-19 Thread Jonathan Gibbons
On 09/19/2013 10:00 AM, Michael Simacek wrote: Hi, I thought about improving performance of the default doclet implementation a bit. According to profiler results, most of the CPU time is spent in constructing the member map in VisibleMemberMap.java. So I've rewritten part of the VisbleMemberM

Re: VisibleMemberMap.java possible performance improvements

2013-09-19 Thread Jonathan Gibbons
On 09/19/2013 10:00 AM, Michael Simacek wrote: Is there any chance of this patch (attached) being accepted into OpenJDK? I've never made any contribution to OpenJDK before, so I would like to ask for code review and guidance through the contribution process. Michael For reference, the general

Re: VisibleMemberMap.java possible performance improvements

2013-09-19 Thread Jonathan Gibbons
On 09/19/2013 10:00 AM, Michael Simacek wrote: Hi, I thought about improving performance of the default doclet implementation a bit. According to profiler results, most of the CPU time is spent in constructing the member map in VisibleMemberMap.java. So I've rewritten part of the VisbleMemberM