On Sat, 22 May 2021 20:57:39 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple primarily-doc update for HtmlStyle.
>
> The change is mostly grouping and commenting items.
>
> Some existing comments were incorrect and have been updated.
Looks good.
-
Marked as revie
On Sat, 22 May 2021 16:18:00 GMT, Jonathan Gibbons wrote:
> Please review a simple `noreg-cleanup` change to remove some dead code.
Looks good, but I found another potential cleanup target close by (see inline
comment).
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resourc
> When a method is said to be called "on an object", this means that the object
> is a receiver. When a method is said to be called "with an object", this
> means that the object is a parameter.
>
> To scan an instance of (Doc)Tree, the "scan" method is called on the instance
> of (Doc)TreeScan
On Mon, 17 May 2021 19:01:01 GMT, Jan Lahoda wrote:
>> Good work. There's a lot to take in here. I think overall, it holds up well
>> - I like how case labels have been extended to accommodate for patterns. In
>> the front-end, I think there are some questions over the split between Attr
>> an
- Mail original -
> De: "Evgeny Mandrikov"
> À: "build-dev" , "compiler-dev"
> , "core-libs-dev"
> , "javadoc-dev"
> Envoyé: Mardi 25 Mai 2021 11:32:03
> Objet: Re: RFR: 8262891: Compiler implementation for Pattern Matching for
> switch (Preview) [v4]
> On Mon, 17 May 2021 19:01:01 GMT
On Wed, 19 May 2021 08:00:12 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/j
On Tue, 25 May 2021 12:20:02 GMT, Jan Lahoda wrote:
> Thanks Evgeny, I'll take a look.
>
> @forax, do you mean why there is "0" in:
> 11: invokedynamic #13, 0
> ?
Not this one, the one on the stack.
7: iconst_0 < this zero
8: istore_3
9: aload_2
10: iload_3
11: invokedynamic #13, 0 // In
On Tue, 25 May 2021 14:13:55 GMT, Rémi Forax wrote:
> 7: iconst_0 < this zero
@forax as far as I understood this will be a value of
parameter `startIndex` in `java.lang.runtime. SwitchBootstraps.doSwitch` 😉
Please correct me @lahodaj if I'm wrong.
-
PR: https://git.openjdk.jav
On Tue, 25 May 2021 14:13:55 GMT, Rémi Forax wrote:
> > Thanks Evgeny, I'll take a look.
> > @forax, do you mean why there is "0" in:
> > 11: invokedynamic #13, 0
> > ?
>
> Not this one, the one on the stack.
>
> 7: iconst_0 < this zero
> 8: istore_3
> 9: aload_2
> 10: iload_3
> 11: invoked
On Mon, 24 May 2021 21:05:02 GMT, Pavel Rappo wrote:
> When a method is said to be called "on an object", this means that the object
> is a receiver. When a method is said to be called "with an object", this
> means that the object is a parameter.
>
> To scan an instance of (Doc)Tree, the "sca
On Sat, 22 May 2021 20:57:39 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple primarily-doc update for HtmlStyle.
>
> The change is mostly grouping and commenting items.
>
> Some existing comments were incorrect and have been updated.
This pull request has now been integrated.
On Tue, 25 May 2021 08:36:13 GMT, Hannes Wallnöfer wrote:
>> Please review a simple `noreg-cleanup` change to remove some dead code.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
> line 580:
>
>> 578: display:inline-block;
>> 579: }
>> 580:
On Tue, 25 May 2021 14:22:57 GMT, Jan Lahoda wrote:
> The reason for this integer (which is not a constant in the case of this
> switch) is to restart the matching in case guards fail to "match".
> Considering the example here:
>
> ```
> class Example {
> void example(Object o) {
>
On Tue, 25 May 2021 16:00:43 GMT, Rémi Forax wrote:
> > The reason for this integer (which is not a constant in the case of this
> > switch) is to restart the matching in case guards fail to "match".
> > Considering the example here:
> > ```
> > class Example {
> > void example(Object o
Although the `com.sun.tools.javadoc.**` packages were removed in JDK-8215584,
some references to them remain, mainly in the form of links in doc comments.
Some of those links refer to classes that never existed, which I reckon is due
to a typo; for example, this reference
com.sun.tools.java
On Tue, 25 May 2021 17:32:11 GMT, Pavel Rappo wrote:
> Although the `com.sun.tools.javadoc.**` packages were removed in JDK-8215584,
> some references to them remain, mainly in the form of links in doc comments.
> Some of those links refer to classes that never existed, which I reckon is
> due
On Tue, 25 May 2021 17:32:11 GMT, Pavel Rappo wrote:
> Although the `com.sun.tools.javadoc.**` packages were removed in JDK-8215584,
> some references to them remain, mainly in the form of links in doc comments.
> Some of those links refer to classes that never existed, which I reckon is
> due
On Tue, 25 May 2021 17:39:13 GMT, Jonathan Gibbons wrote:
>> Although the `com.sun.tools.javadoc.**` packages were removed in
>> JDK-8215584, some references to them remain, mainly in the form of links in
>> doc comments. Some of those links refer to classes that never existed, which
>> I reck
On Tue, 25 May 2021 17:46:59 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java line
>> 627:
>>
>>> 625: }
>>> 626:
>>> 627: /** @see com.sun.tools.javadoc.ClassDocImpl#findField */
>>
>> Is there an equivalent new-style method that
On Tue, 25 May 2021 14:57:58 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
>> line 580:
>>
>>> 578: display:inline-block;
>>> 579: }
>>> 580: div.block div.deprecation-comment, div.block div.block
>>> span.emphas
On Sat, 22 May 2021 16:18:00 GMT, Jonathan Gibbons wrote:
> Please review a simple `noreg-cleanup` change to remove some dead code.
This pull request has now been integrated.
Changeset: 594d4544
Author:Jonathan Gibbons
URL:
https://git.openjdk.java.net/jdk/commit/594d4544759a240690e
> Please review a simple `noreg-cleanup` change to remove some dead code.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains four addition
On Tue, 25 May 2021 18:49:10 GMT, Pavel Rappo wrote:
>> The most likely justification for all these ClassDocImpl references is now
>> in `ReferenceTree`.
>
> A doc comment consisting solely of an `@see` tag has unclear semantics. The
> methods I removed such doc comments from are private and ca
On Tue, 25 May 2021 22:17:51 GMT, Jonathan Gibbons wrote:
>> A doc comment consisting solely of an `@see` tag has unclear semantics. The
>> methods I removed such doc comments from are private and can be used only
>> from their enclosing instance.
>
> Let me go do some archaeology. While the co
On Tue, 25 May 2021 17:32:11 GMT, Pavel Rappo wrote:
> Although the `com.sun.tools.javadoc.**` packages were removed in JDK-8215584,
> some references to them remain, mainly in the form of links in doc comments.
> Some of those links refer to classes that never existed, which I reckon is
> due
Please review a new test to track the differences between `HtmlStyle.java` and
`stylesheet.css`.
The test passes, because all discrepancies are noted within the test. However,
some of the discrepancies may indicate the need for follow-up work, such as
adding new items to `HtmlStyle` for documen
26 matches
Mail list logo
