Re: RFR: JDK-8272984: javadoc support for reproducible builds [v2]

2022-01-25 Thread Hannes Wallnöfer
On Mon, 24 Jan 2022 19:04:18 GMT, Jonathan Gibbons wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java >> line 370: >> >>> 368: try { >>> 369: date = ZonedDateTime.parse(arg, >>> DateTimeFormatter.ISO

Re: RFR: JDK-8272984: javadoc support for reproducible builds [v2]

2022-01-25 Thread Jonathan Gibbons
On Tue, 25 Jan 2022 11:04:42 GMT, Hannes Wallnöfer wrote: >> I went out of my way to ensure that the _output_ form was not affected, in >> case there is anyone relying on the existing format ... and yes, we have >> tests for that as well. >> >> I'd be open to formally changing the format of th

Re: RFR: JDK-8272984: javadoc support for reproducible builds [v4]

2022-01-25 Thread Jonathan Gibbons
> Please review a javadoc update to support a new `--date` option to support > reproducible builds. > > This pull request supersedes https://github.com/openjdk/jdk/pull/6905. In > that PR, the `SOURCE_DATE_EPOCH` environment variable was used to provide the > time stamp, but review feedback sug

RFR: JDK-8280488: doclint reference checks withstand warning suppression

2022-01-25 Thread Jonathan Gibbons
Please review a small modification to the way that bad references are reported by DocLint. A new "mode" is introduced, `strictReferenceChecks`. If the mode is _not_ set, references that explicitly include a module name when that module name is not resolved in the module graph will be reporte

Re: RFR: JDK-8280488: doclint reference checks withstand warning suppression

2022-01-25 Thread Joe Darcy
On Wed, 26 Jan 2022 02:20:24 GMT, Jonathan Gibbons wrote: > Please review a small modification to the way that bad references are > reported by DocLint. > > A new "mode" is introduced, `strictReferenceChecks`. > > If the mode is _not_ set, references that explicitly include a module name >