On Tue, 5 Jul 2022 11:01:46 GMT, Hannes Wallnöfer wrote:
> Please review a trivial change to use plain font for deprecation comments in
> the Deprecated API page. Italic font is used to make deprecation comments
> stand out against other parts of the documentation, but here the content
> consi
On Thu, 21 Jul 2022 16:35:28 GMT, Pavel Rappo wrote:
> > > This PR could use the feature it introduces. It would test drive the
> > > feature and ensure that the feature works. A brief search showed these
> > > potential candidates in test/langtools/jdk/javadoc/:
> > >
> > > 1. doclet/InheritD
> Please review a simple update to `JavadocTester` to provide a default-on
> check that no stack traces were written to the STDERR stream.
>
> There are also some minor cleanup edits suggested by the IDE.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a r
> Please review a medium-size cleanup related to handling newlines in
> `Content`/`HtmlTree`/`Text[Builder]` trees.
> This is the 3rd and last in the recent series of cleanup tasks in the code to
> generate HTML.
>
> Until recently, the `Text`/`TextBuilder` objects were "ready-for-writing",
> m
On Mon, 8 Aug 2022 10:23:02 GMT, Hannes Wallnöfer wrote:
> This looks quite good. Apart from the inline comments, I wondered about the
> following:
>
> * Would the methods and constant you moved to `Text` be better placed in
> `Content` as they are used in other Content instances?
> * There a
On Mon, 8 Aug 2022 10:15:41 GMT, Hannes Wallnöfer wrote:
>> Please review a medium-size cleanup related to handling newlines in
>> `Content`/`HtmlTree`/`Text[Builder]` trees.
>> This is the 3rd and last in the recent series of cleanup tasks in the code
>> to generate HTML.
>>
>> Until recently
On Mon, 8 Aug 2022 10:03:05 GMT, Hannes Wallnöfer wrote:
>> Please review a medium-size cleanup related to handling newlines in
>> `Content`/`HtmlTree`/`Text[Builder]` trees.
>> This is the 3rd and last in the recent series of cleanup tasks in the code
>> to generate HTML.
>>
>> Until recently
On Tue, 5 Jul 2022 11:01:46 GMT, Hannes Wallnöfer wrote:
> Please review a trivial change to use plain font for deprecation comments in
> the Deprecated API page. Italic font is used to make deprecation comments
> stand out against other parts of the documentation, but here the content
> consi
On Mon, 25 Jul 2022 15:10:36 GMT, Hannes Wallnöfer wrote:
> This is a simple change to automatically generate `id` attributes for HTML
> headers in documentation comments.
>
> I decided to leave the functionality in `HtmlDocletWriter` rather than moving
> it to `HtmlIds` because it uses the s
On Thu, 11 Aug 2022 15:29:46 GMT, Hannes Wallnöfer wrote:
> Please review a change to use CSS custom properties (aka variables) to define
> the fonts and colors in generated documentation. It is now possible to change
> the fonts and colors of generated API documentation by changing the values
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9445
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
Those `.properties` bundle changes look good.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9445
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
`jdk.compiler` and `jdk.javadoc` changes look OK
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9445
13 matches
Mail list logo
