Re: RFR: 8289562: Change bugs.java.com and bugreport.java.com URL's to https [v2]

2022-08-18 Thread Joe
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https Joe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since

Integrated: JDK-8236048: Cleanup use of Utils.normalizeNewlines

2022-08-18 Thread Jonathan Gibbons
On Sat, 30 Jul 2022 00:36:06 GMT, Jonathan Gibbons wrote: > Please review a medium-size cleanup related to handling newlines in > `Content`/`HtmlTree`/`Text[Builder]` trees. > This is the 3rd and last in the recent series of cleanup tasks in the code to > generate HTML. > > Until recently, the

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page

2022-08-18 Thread Jonathan Gibbons
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to the preview page to add a list of preview > features and allow users to explore the preview APIs by feature. > > While the changes for the enhancement itself are not overly complex, the work > entailed

Re: RFR: 8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag

2022-08-18 Thread Pavel Rappo
On Mon, 4 Jul 2022 15:05:20 GMT, Andrey Turbanov wrote: >> 265 commits seem to be quite a divergence between this PR branch and >> openjdk:master. I know that sometimes it seems not to be worth the hassle, >> but please merge openjdk:master into this PR branch. If nothing else, it >> will trig

Re: RFR: JDK-8236048: Cleanup use of Utils.normalizeNewlines [v2]

2022-08-18 Thread Hannes Wallnöfer
On Tue, 16 Aug 2022 22:22:37 GMT, Jonathan Gibbons wrote: >> Please review a medium-size cleanup related to handling newlines in >> `Content`/`HtmlTree`/`Text[Builder]` trees. >> This is the 3rd and last in the recent series of cleanup tasks in the code >> to generate HTML. >> >> Until recentl

Re: RFR: JDK-8289334: Use CSS variables to define fonts and colors

2022-08-18 Thread Hannes Wallnöfer
On Thu, 11 Aug 2022 15:29:46 GMT, Hannes Wallnöfer wrote: > Please review a change to use CSS custom properties (aka variables) to define > the fonts and colors in generated documentation. It is now possible to change > the fonts and colors of generated API documentation by changing the values

Integrated: JDK-8289334: Use CSS variables to define fonts and colors

2022-08-18 Thread Hannes Wallnöfer
On Thu, 11 Aug 2022 15:29:46 GMT, Hannes Wallnöfer wrote: > Please review a change to use CSS custom properties (aka variables) to define > the fonts and colors in generated documentation. It is now possible to change > the fonts and colors of generated API documentation by changing the values

Re: RFR: JDK-8289334: Use CSS variables to define fonts and colors

2022-08-18 Thread Hannes Wallnöfer
On Thu, 11 Aug 2022 15:29:46 GMT, Hannes Wallnöfer wrote: > Please review a change to use CSS custom properties (aka variables) to define > the fonts and colors in generated documentation. It is now possible to change > the fonts and colors of generated API documentation by changing the values