On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the
> `test/langtools` files? This was originally raised by @mernst in
> https://github.com/openjdk/jdk/pull/10029, but given that the other PR
> touches multiple other ar
On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the
> `test/langtools` files? This was originally raised by @mernst in
> https://github.com/openjdk/jdk/pull/10029, but given that the other PR
> touches multiple other ar
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Tue, 22 Nov 2022 23:17:24 GMT, Jonathan Gibbons wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-829736
On Tue, 29 Nov 2022 22:27:46 GMT, Daniel D. Daugherty
wrote:
>> test/jdk/jdk/internal/vm/Continuation/Fuzz.java line 90:
>>
>>> 88:
>>> 89: public static void main(String[] args) {
>>> 90: if (Platform.isSlowDebugBuild() && Platform.isOSX() &&
>>> Platform.isAArch64()) {
>>
>> I
On Wed, 23 Nov 2022 02:28:02 GMT, Chris Plummer wrote:
> Do you plan on closing the CRs associated with these changes even though the
> root causes are not being addressed, just avoided?
These two CRs are like ProblemListing bugs:
[JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367): dis
On Wed, 23 Nov 2022 17:51:20 GMT, Leonid Mesnik wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367)
On Wed, 23 Nov 2022 00:05:54 GMT, Serguei Spitsyn wrote:
>> Does langtools have its own test libraries that I can use to ask the same
>> questions?
>
> Sorry, I was not clear.
> The Fuzz.java has this order:
>
> +import jdk.test.lib.Platform;
> +import jtreg.SkippedException;
>
> I thought, yo
On Wed, 23 Nov 2022 02:16:30 GMT, David Holmes wrote:
>> @jonathan-gibbons - Thanks for the review!
>>
>> I could not find an @requires incantation for saying
>> do-not-use-slowdebug-bits
>> nor one for saying do-not-use-macosx-aarch64. I don't really do a lot with
>> @requires so I could be mi
On Tue, 22 Nov 2022 19:43:38 GMT, Serguei Spitsyn wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
Hi -
I need to repeat again. Please avoid using www.ietf.org as the URL base
for referencing RFCs. The appropriate location is www.rfc-editor.org
and is going to be more stable in the long run than any reference to an
RFC that runs through the IETF's website. These two websites have
differ
On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the
> `test/langtools` files? This was originally raised by @mernst in
> https://github.com/openjdk/jdk/pull/10029, but given that the other PR
> touches multiple other ar
On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the
> `test/langtools` files? This was originally raised by @mernst in
> https://github.com/openjdk/jdk/pull/10029, but given that the other PR
> touches multiple other ar
On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the
> `test/langtools` files? This was originally raised by @mernst in
> https://github.com/openjdk/jdk/pull/10029, but given that the other PR
> touches multiple other ar
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Thu, 17 Nov 2022 14:15:52 GMT, Hannes Wallnöfer wrote:
> Please review the addition of a new JavaDoc test to check the version of 3rd
> party libraries in legal files against the versions of actual library code.
> The skeleton for this test (mostly looking up files in the source tree) was
>
On Fri, 11 Nov 2022 15:17:23 GMT, Hannes Wallnöfer wrote:
> Please review a patch to complete the conversion of the javadoc style sheet
> to use CSS custom properties for all colors and fonts.
>
> A few notes for changes that may not be self-explanatory:
>
> - I renamed the `--highlight` pro
On Tue, 29 Nov 2022 01:43:32 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use jtreg.SkippedException
>
> test/langtools/jdk/javadoc/doclet/checkLibraryVersions/CheckLibraryVersions.java
> Please review the addition of a new JavaDoc test to check the version of 3rd
> party libraries in legal files against the versions of actual library code.
> The skeleton for this test (mostly looking up files in the source tree) was
> taken from `CheckManPageOptions.java`. The test uses a regu
On Tue, 22 Nov 2022 14:38:34 GMT, Hannes Wallnöfer wrote:
> Please review a fix for a bug where a method's parameter type could "mask" a
> method and result in the method to not appear in the search results. The fix
> consists in checking whether a match covers an element's name in the match
>
On Tue, 29 Nov 2022 00:53:34 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove duplicate option
>
> test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java line
> 34
> Please review a fix for a bug where a method's parameter type could "mask" a
> method and result in the method to not appear in the search results. The fix
> consists in checking whether a match covers an element's name in the match
> loop.
>
> Note that the added test must be run manually a
23 matches
Mail list logo
