Re: RFR: JDK-8300914: Allow `@` as an escape in documentation comments [v5]

2023-02-06 Thread Jonathan Gibbons
> Please review a moderately simple update to permit the use of `@` as the > escape character in a limited set of escape sequences. Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: Improve spec wording - Changes: -

Re: RFR: JDK-8300914: Allow `@` as an escape in documentation comments [v4]

2023-02-06 Thread Jonathan Gibbons
> Please review a moderately simple update to permit the use of `@` as the > escape character in a limited set of escape sequences. Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge with upstream

Re: RFR: JDK-8301810: Bug in doctree DocCommentTester.compress [v2]

2023-02-06 Thread Jonathan Gibbons
> Please review a minor but long-standing bug in the code to "compress" long > strings in the `doctree` `DocCommentTester` class. > > The primary change is in `DocCommentTester`, to fix the code, and make it > somewhat more robust. The change does break some golden output, in comments > and fi

Integrated: 8301813: Bad caret position in error message

2023-02-06 Thread Jonathan Gibbons
On Fri, 3 Feb 2023 22:56:58 GMT, Jonathan Gibbons wrote: > Please review a trivial update to `DocCommentParser` and corresponding > updates to tests, to fix the caret position in the two forms of the "no tag > name found" error message. > > The fix is simply to use the overload of `erroneous`

Re: RFR: 8301813: Bad caret position in error message

2023-02-06 Thread Iris Clark
On Fri, 3 Feb 2023 22:56:58 GMT, Jonathan Gibbons wrote: > Please review a trivial update to `DocCommentParser` and corresponding > updates to tests, to fix the caret position in the two forms of the "no tag > name found" error message. > > The fix is simply to use the overload of `erroneous`