Re: RFR: JDK-8305620: Missing `break` in DocCommentParser `inlineWord()`

2023-04-04 Thread Iris Clark
On Tue, 4 Apr 2023 23:58:28 GMT, Jonathan Gibbons wrote: > Please review a fix for the `depth` counting in `DocCommentParser` > `inlineWord`. > There was a missing break that caused the count to go high, and because of > that the code for the down count needed to be adjusted as well. > > The t

RFR: JDK-8305620: Missing `break` in DocCommentParser `inlineWord()`

2023-04-04 Thread Jonathan Gibbons
Please review a fix for the `depth` counting in `DocCommentParser` `inlineWord`. There was a missing break that caused the count to go high, and because of that the code for the down count needed to be adjusted as well. The test is modified to be stylistically more like the others with `abc` and

RFR: JDK-8305591: Cleanup use of `newline` flag in DocCommentParser

2023-04-04 Thread Jonathan Gibbons
Please remove a simple cleanup fix, to remove unnecessary assignments to set the `newline` flag to `true` in `DocCommentParser`. The flag is always set appropriately in `nextChar()`. This removes a number of "fall-through" cases in switch statements. In reviewing the use of `@SuppressWarnings(

Re: [External] : Re: Snippet specification feedback

2023-04-04 Thread Pavel Rappo
> On 31 Mar 2023, at 13:50, Tagir Valeev wrote: > > > >> It's good that you are looking into this, because it pushes us to improve >> the spec. That said, even javadoc is qui We might want an API, such as the >> one described in this comment >> https://bugs.openjdk.org/browse/JDK-8304408?