On Tue, 9 May 2023 03:11:10 GMT, Chen Liang wrote:
> Please review this simple patch that fixes the package determination for
> nested classes in the `@sealedGraph` taglet.
>
> Current JDK 21:
> https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/lang/foreign/MemoryLayout.
`@sealedGraph` had a mechanism to render non-sealed classes differently, but
it's useless because the graph nodes are not bordered. This patch converts the
non-sealed classes to be rendered in italics instead.
An example of `ConstantDesc`, which has a sealed hierarchy except
`DynamicConstantDes
Please review this simple patch that fixes the package determination for nested
classes in the `@sealedGraph` taglet.
Current JDK 21:
https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/lang/foreign/MemoryLayout.html
https://download.java.net/java/early_access/jdk21/docs/api
On Mon, 8 May 2023 13:50:30 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template
>> line 417:
>>
>>> 415: hdr.append(" >> aria-label='" + messages.linkToSection
>>> 416: + "'>>> 417:
> Please review a change to use plain HTML links instead of buttons to provide
> the URL to page section/heading anchors. Special care was taken to retain the
> accessibility features added in JDK-8299718, so section links can be reached
> and activated by keyboard and have an `aria-label` attri
> Please review a change to use plain HTML links instead of buttons to provide
> the URL to page section/heading anchors. Special care was taken to retain the
> accessibility features added in JDK-8299718, so section links can be reached
> and activated by keyboard and have an `aria-label` attri
On Fri, 5 May 2023 17:47:38 GMT, Jonathan Gibbons wrote:
>> Please review a change to use plain HTML links instead of buttons to provide
>> the URL to page section/heading anchors. Special care was taken to retain
>> the accessibility features added in JDK-8299718, so section links can be
>> r
On Fri, 5 May 2023 17:56:52 GMT, Jonathan Gibbons wrote:
>
> * I'm mildly surprised the links show up on some of the "standard"
> "internal" headings, like "Constructor Details". I guess there may be cases
> where this is wanted, and maybe if you didn't do it, we would get a RFE to do
> i
On Thu, 4 May 2023 18:01:10 GMT, Jonathan Gibbons wrote:
> Please review a simple fix to remove unnecessary detail from in-page and
> console messages about the name of the tag enclosing a bad reference.
Looks good to me.
-
Marked as reviewed by hannesw (Reviewer).
PR Review: htt
On Tue, 18 Apr 2023 12:42:05 GMT, Hannes Wallnöfer wrote:
> Please review a simple fix for the javadoc `TestSearchScript` test which is
> skipped during normal test runs and only run manually. This adds a test file
> which was missing in a previous commit and a mock function for jQuery method
10 matches
Mail list logo
