Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2023-05-11 Thread Naoto Sato
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2023-05-11 Thread Justin Lu
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2023-05-11 Thread Justin Lu
> This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the > .properties files as UTF-8 during the conversion fro

Re: RFR: JDK-8305713: DocCommentParser: merge blockContent and inlineContent [v6]

2023-05-11 Thread Jonathan Gibbons
On Wed, 19 Apr 2023 14:17:57 GMT, Jonathan Gibbons wrote: >> Please review a cleanup in DocCommentParser to merge blockContent and >> inlineContent into a single method to parse "rich content" in a doc comment. >> >> **Note:** This is dependent on PR #13362, to convert `DocCommentParser` to >>

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v2]

2023-05-11 Thread KIRIYAMA Takuya
On Fri, 5 May 2023 17:30:51 GMT, Jonathan Gibbons wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8306980: Generated docs should contain correct GPLv2 Legal Documents > > The change to use a mixture of `Path` an

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v2]

2023-05-11 Thread KIRIYAMA Takuya
> I modified the location from which javadoc copies some legal files to the > generated documentation. If --legal-notices option is set to default or > nothing is specified,, GPLv2 Legal Documents are copied from legal/java.base/ > directory, such as LICENSE, ADDITIONAL_LICENSE_INFO and ASSEMBL