Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-26 Thread Justin Lu
On Thu, 27 Jul 2023 00:16:34 GMT, Damon Nguyen wrote: >> Please review this PR which contains the translations for updates to >> localized resources in the JDK since RDP1. >> >> Included in this change are improved translations for certain values, which >> also includes global updates for tran

Re: RFR: 8311517: Add performance information to ArrayList javadoc

2023-07-26 Thread dan1st
On Wed, 26 Jul 2023 21:59:41 GMT, Stuart Marks wrote: > Regarding the text of the change: should getFirst() and getLast() be > mentioned? They were added by Sequenced Collections, and they run in constant > time. Also, while add() and addLast() run in amortized constant time (because > of the

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-07-26 Thread dan1st
> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, and listIterator operations run in > constant time. The add operation run

RFR: JDK-8312201: Cleanup common behavior in "page writers" and "member writers"

2023-07-26 Thread Jonathan Gibbons
Please review a medium change that is a follow-up to recent work to cleanup the builders and writers in the doclet. This change is primarily focussed on cleaning up the code to generate summary tables for each kind of member. The bulk of the code is moved from `ClassWriter` to `AbstractMemberWr

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-26 Thread Damon Nguyen
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote: > Please review this PR which contains the translations for updates to > localized resources in the JDK since RDP1. > > Included in this change are improved translations for certain values, which > also includes global updates for translations

Re: RFR: 8311517: ArrayList javadoc improvements related to sequenced collection updates

2023-07-26 Thread Stuart Marks
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote: > The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, and listIterator operati

Re: RFR: 8311517: ArrayList javadoc improvements related to sequenced collection updates

2023-07-26 Thread dan1st
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote: > The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, and listIterator operati

Re: RFR: 8311517: ArrayList javadoc improvements related to sequenced collection updates

2023-07-26 Thread Stuart Marks
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote: > The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, and listIterator operati

Re: RFR: 8311517: ArrayList javadoc improvements related to sequenced collection updates

2023-07-26 Thread Stuart Marks
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote: > The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, and listIterator operati

RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-26 Thread Justin Lu
Please review this PR which contains the IPS translations for updates to localized resources in the JDK since RDP1. Included in this change are improved translations for certain values, which also includes global updates for translations of the words 'annotation' and 'file' for zh_CN. The foll

RFR: JDK-8313204: Inconsistent order of sections in generated class documentation

2023-07-26 Thread Jonathan Gibbons
Please review a minor change to `ClassWriter` to make the order of sections consistent across member-kinds and between summary and detail sections. The change to `ClassWriter` is just to reorder the sections, and to add some explanatory comments. One test detected the change and is therefore up

Integrated: JDK-8312445: Array types in annotation elements show square brackets twice

2023-07-26 Thread Hannes Wallnöfer
On Tue, 25 Jul 2023 13:29:55 GMT, Hannes Wallnöfer wrote: > Please review a change to fix the representation of array types as values of > annotation elements in javadoc-generated documentation. > > The primary fix is to avoid generating duplicate `[]` brackets for array > types, but there are

Re: RFR: JDK-8312445: Array types in annotation elements show square brackets twice [v3]

2023-07-26 Thread Pavel Rappo
On Wed, 26 Jul 2023 10:50:16 GMT, Hannes Wallnöfer wrote: >> Please review a change to fix the representation of array types as values of >> annotation elements in javadoc-generated documentation. >> >> The primary fix is to avoid generating duplicate `[]` brackets for array >> types, but ther

Re: RFR: JDK-8312445: Array types in annotation elements show square brackets twice [v3]

2023-07-26 Thread Hannes Wallnöfer
> Please review a change to fix the representation of array types as values of > annotation elements in javadoc-generated documentation. > > The primary fix is to avoid generating duplicate `[]` brackets for array > types, but there are a few secondary improvements: > > - When linking to a typ

Re: RFR: JDK-8312445: Array types in annotation elements show square brackets twice [v2]

2023-07-26 Thread Pavel Rappo
On Wed, 26 Jul 2023 09:11:20 GMT, Hannes Wallnöfer wrote: >> Please review a change to fix the representation of array types as values of >> annotation elements in javadoc-generated documentation. >> >> The primary fix is to avoid generating duplicate `[]` brackets for array >> types, but ther

Re: RFR: JDK-8312445: Array types in annotation elements show square brackets twice [v2]

2023-07-26 Thread Hannes Wallnöfer
> Please review a change to fix the representation of array types as values of > annotation elements in javadoc-generated documentation. > > The primary fix is to avoid generating duplicate `[]` brackets for array > types, but there are a few secondary improvements: > > - When linking to a typ

Re: RFR: JDK-8312445: Array types in annotation elements show square brackets twice

2023-07-26 Thread Hannes Wallnöfer
On Tue, 25 Jul 2023 15:32:22 GMT, Pavel Rappo wrote: >> Please review a change to fix the representation of array types as values of >> annotation elements in javadoc-generated documentation. >> >> The primary fix is to avoid generating duplicate `[]` brackets for array >> types, but there are