Re: RFR: JDK-8317693: Unused parameter to Tokens.Token.comment method

2023-10-06 Thread Iris Clark
On Fri, 6 Oct 2023 23:39:27 GMT, Jonathan Gibbons wrote: > Please review a simple cleanup to eliminate an unused parameter and rename > the enclosing method. > > No new tests; bug is primarily `noreg-cleanup`. Two tests were affected by > the change, but are not in themselves tests for the cha

RFR: JDK-8317693: Unused parameter to Tokens.Token.comment method

2023-10-06 Thread Jonathan Gibbons
Please review a simple cleanup to eliminate an unused parameter and rename the enclosing method. No new tests; bug is primarily `noreg-cleanup`. Two tests were affected by the change, but are not in themselves tests for the change. - Commit messages: - JDK-8317693: Unused paramete

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

2023-10-06 Thread Jonathan Gibbons
On 10/5/23 6:58 PM, Jaikiran Pai wrote: On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote: I modified the location from which javadoc copies some legal files to the generated documentation. If --legal-notices option is set to default or nothing is specified,, GPLv2 Legal Documents a