Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Chen Liang
On Wed, 8 Nov 2023 15:45:56 GMT, Konrad Windszus wrote: > I know, but for memory consumption reasons everyone should prefer just > passing an InputStream. Is the memory consumption with > `ClassFile.of().parse(Path)` any better (i.e. are you using a > `java.io.RandomAccessFile` or `java.nio.ch

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v2]

2023-11-08 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments

2023-11-08 Thread Pavel Rappo
On Wed, 8 Nov 2023 17:25:36 GMT, Pavel Rappo wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `jdk.int

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments

2023-11-08 Thread Pavel Rappo
On Thu, 26 Oct 2023 23:29:00 GMT, Jonathan Gibbons wrote: > Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.inte

Re: RFR: 8308753: Class-File API transition to Preview [v26]

2023-11-08 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v25]

2023-11-08 Thread Adam Sotona
On Wed, 8 Nov 2023 15:22:54 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 360 commits: >> >> - fixed condy tests >> - Merge branch 'master' into JDK-8308753-preview >> - Merge branch 'mas

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Konrad Windszus
On Wed, 8 Nov 2023 14:07:04 GMT, Chen Liang wrote: > You can simply call `ClassFile.of().parse(inputStream.readAllBytes())` > instead. I know, but for memory consumption reasons everyone should prefer just passing an InputStream. Is the memory consumption with `ClassFile.of().parse(Path)` any

Re: RFR: 8308753: Class-File API transition to Preview [v25]

2023-11-08 Thread Chen Liang
On Wed, 8 Nov 2023 14:32:52 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v25]

2023-11-08 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Chen Liang
On Wed, 8 Nov 2023 13:31:32 GMT, Konrad Windszus wrote: > I would appreciate a hint in the javadocs why `Classfile.of` requires a byte > array and cannot deal with inputstreams (iiuc this is due to the lazy reading > which requires adjusting the offset back and forth potentially) You can simpl

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name

2023-11-08 Thread psoujany
On Wed, 11 Oct 2023 12:28:00 GMT, psoujany wrote: > Interactive component with ARIA role 'tabpanel' does not have a > programmatically associated name in javadoc which is failing Accessibility > checks. > https://bugs.openjdk.org/browse/JDK-8311893 > https://bugs.openjdk.org/browse/JDK-8311894

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Konrad Windszus
On Fri, 3 Nov 2023 08:39:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a